search

SC2Mapster / sc2layout-schema

XML Schema of SC2Layout document from StarCraft II.
4 stars 3 forks source link

Missing stuff from in-between 4.10 and 5.0 #4

Open Talv opened 3 months ago

Talv commented 3 months ago

Found these after running a check over the content of the repo.

Talv commented 3 months ago

Thanks @R-P-S . I've tweaked permissions a bit - can you check whether you can push tags to repo? Like for instance tag the latest commit as v6.4, so that users of VSC extension will receive that update.

Talv commented 3 months ago

As far as other frames / properties go, this is mostly GlueUI stuff. So not really important for most of people :P

Furthermore stuff like BattleTradeShow* / Perf* frames are kinda non functional / non quite present in the retail build of the game. At least I've not been able to use them, but maybe they must be created from special context or something.

Though, if you wanted to explore/add these too I can send you a tool that allows toggling UI inspector in game menus (DM me on discord on mail me if you're interested).

R-P-S commented 3 months ago

Accessed was denied when pushing the tag to the repo

Talv commented 3 months ago

Hmm, please re-try. I've explicitly added you now as member with Maintain access. (Previously the permissions were from the team you were part of, maybe that's why it didn't work).

image

I know, I could push the tag myself, but just wanna figure out why it didn't work and future-proof the permissions :P