search

SC5 / gulp-bobrsass-boilerplate

Gulp BoBrSASS Boilerplate
7 stars 13 forks source link

Refactor build away from production dependencies. Also fixes #29 and #12 #33

Closed laurisvan closed 9 years ago

laurisvan commented 9 years ago

This is a rather major refactoring of the build process - all build (and hence all development dependencies) out from dependencies to devDependencies. This also enables faster Docker builds (only copy the production deps).

This also necessitates bundling a tiny express file server (into production).

If this is fine & dandy, I'll make another PR where the dist files are watched for changes and subsequent docker builds won't always copy everything there.

laurisvan commented 9 years ago

@juhamust Docker folks prefer COPY over ADD (https://docs.docker.com/articles/dockerfile_best-practices/#add-or-copy) - while I don't know if it makes any difference over here, I'll go along that way.

Right now the copy process is minimal, but indeed the two-phase copy split you suggested makes sense. At the same time, I noticed the exclusion of Dockerfile from the bulid does more harm than good.

Thanks for the suggestions, I made the changes as you requested.

laurisvan commented 9 years ago

In absence of further comments, I'll merge this one. Thenafter we can merge the changes to our outdated AngularJS branch which makes us all much happier.