search

SC5 / gulp-bobrsass-boilerplate

Gulp BoBrSASS Boilerplate
7 stars 13 forks source link

Bundle.js does not recognise bower dependencies #37

Open IikkaWinter opened 9 years ago

IikkaWinter commented 9 years ago

As the bundle.js file is created by gulpfile config, it does not recognise bower dependencies, hence libraries are not injected in correct order.

laurisvan commented 9 years ago

Hmm... There's a bowerFiles() call to pick the "main JS files" from Bower manifests. Properly packaged bower components should work alright? Can you point me to the lib that fails in your case? I could check whether the problem is in the manifest or gulpfile itself.

IikkaWinter commented 9 years ago

For instance we had to manually add angular-translate to bundle.

Iikka Winter Lead Developer/UX Developer SC5 Online Ltd iikka.winter@sc5.io +358 50 315 3117

On 01 Feb 2015, at 22:36, Lauri Svan notifications@github.com wrote:

Hmm... There's a bowerFiles() call to pick the "main JS files" from Bower manifests. Properly packaged bower components should work alright? Can you point me to the lib that fails in your case? I could check whether the problem is in the manifest or gulpfile itself.

— Reply to this email directly or view it on GitHub.

artoliukkonen commented 9 years ago

I know this issue is old, however here's solution in case someone is still facing same issues.

In case bower component doesn't specify main file (so it wouldn't be bundled), you can override this in your projects bower.json . For options, see https://github.com/ck86/main-bower-files#overrides-options

In your case, looks like angular-translate was patched some days after you noticed the issue https://github.com/angular-translate/angular-translate/commit/3a1ad10b768b64b1eaf0ace03a66458fd73cb931