search

SC5 / sc5-styleguide

Styleguide generator is a handy little tool that helps you generate good looking styleguides from stylesheets using KSS notation
http://styleguide.sc5.io/
MIT License
1.26k stars 167 forks source link

sg-wrapper being ignored all over the project #1027

Closed marinho closed 7 years ago

marinho commented 7 years ago

I am a beginner in sc5-styleguide.

I've just created my own project copying the files package.json and gulpfile.js from sc5-styleguide-tutorial.

The styleguide is generated alright, including sg-insert and basic KSS support, but when sg-wrapper is completely ignored. No errors. Just the built styleguide renders the markup without wrapping HTML.

Funny that I couldn't see any difference between my code and sc5-styleguide-tutorial, but sc5-styleguide-tutorial generates atoms.scss correctly with sg-wrapper.

Here is the gist of gulpfile.js and one of my scss files:

Update

I noticed that sc5-stylesheet version was quite outdated in sc5-stylesheet-tutorial. So I replaced my gulp.js by the example provided in the README.md file, as in the gist below. But the issue with sg-wrapper still happens.

marinho commented 7 years ago

Ooh, I found why: the KSS notation had a white space after the double slash comment just above sg-wrapper, as below:

// </header>
// <--- here
// sg-wrapper:

Curious that it seems KSS itself doesn't prohibit that, and the other spacings between other sections such as Title and Description, Stylesheet, etc. are fine and accepted.

To me, that seems a bug in sc5-styleguide.

varya commented 7 years ago

Thank you. This was a bug. It's fixed here https://github.com/SC5/sc5-styleguide/pull/1031 Please wait for the pull request to be merge and for the next release.