SCALE-MS / scale-ms

SCALE-MS design and development
GNU Lesser General Public License v2.1
4 stars 4 forks source link

Clean up Pilot acquisition. #357

Closed eirrgang closed 1 year ago

eirrgang commented 1 year ago

Note: We need to interact with the RuntimeSession in the main thread whenever possible. Let the RuntimeSession dispatch slow rp UI calls to other threads as needed and appropriate.

TODO(#334):

TODO(#335):

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 66.06% and project coverage change: -1.23 :warning:

Comparison is base (41b965a) 81.04% compared to head (c59f41c) 79.81%.

:exclamation: Current head c59f41c differs from pull request most recent head 04bbe3c. Consider uploading reports for the commit 04bbe3c to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #357 +/- ## ========================================== - Coverage 81.04% 79.81% -1.23% ========================================== Files 30 30 Lines 3361 3429 +68 Branches 513 523 +10 ========================================== + Hits 2724 2737 +13 - Misses 465 512 +47 - Partials 172 180 +8 ``` | [Impacted Files](https://app.codecov.io/gh/SCALE-MS/scale-ms/pull/357?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=SCALE-MS) | Coverage Δ | | |---|---|---| | [src/scalems/radical/runtime.py](https://app.codecov.io/gh/SCALE-MS/scale-ms/pull/357?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=SCALE-MS#diff-c3JjL3NjYWxlbXMvcmFkaWNhbC9ydW50aW1lLnB5) | `74.11% <65.43%> (-5.40%)` | :arrow_down: | | [src/scalems/execution.py](https://app.codecov.io/gh/SCALE-MS/scale-ms/pull/357?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=SCALE-MS#diff-c3JjL3NjYWxlbXMvZXhlY3V0aW9uLnB5) | `76.89% <100.00%> (ø)` | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.