SCALE-MS / scale-ms

SCALE-MS design and development
GNU Lesser General Public License v2.1
4 stars 4 forks source link

Break up scalems.radical modules. #361

Closed eirrgang closed 1 year ago

eirrgang commented 1 year ago

Move everything but RPDispatchingExecutor from scalems.radical.runtime to new modules:

Update scalems.radical.configuration() semantics:

Separate the datastore from the configuration.

Move get_scheduler() to public scalems.radical.raptor module function.

Allow invocation.run() to provide a configuration object to the executor_factory without assuming <module>.configuration() sets global state.

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 76.28% and project coverage change: +18.21 :tada:

Comparison is base (067a0a6) 62.29% compared to head (9ac4bbc) 80.50%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #361 +/- ## =========================================== + Coverage 62.29% 80.50% +18.21% =========================================== Files 29 35 +6 Lines 3421 3540 +119 Branches 522 531 +9 =========================================== + Hits 2131 2850 +719 + Misses 1168 505 -663 - Partials 122 185 +63 ``` | [Impacted Files](https://app.codecov.io/gh/SCALE-MS/scale-ms/pull/361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=SCALE-MS) | Coverage Δ | | |---|---|---| | [src/scalems/radical/manager.py](https://app.codecov.io/gh/SCALE-MS/scale-ms/pull/361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=SCALE-MS#diff-c3JjL3NjYWxlbXMvcmFkaWNhbC9tYW5hZ2VyLnB5) | `69.13% <69.13%> (ø)` | | | [src/scalems/radical/runtime\_configuration.py](https://app.codecov.io/gh/SCALE-MS/scale-ms/pull/361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=SCALE-MS#diff-c3JjL3NjYWxlbXMvcmFkaWNhbC9ydW50aW1lX2NvbmZpZ3VyYXRpb24ucHk=) | `74.59% <74.59%> (ø)` | | | [src/scalems/radical/task.py](https://app.codecov.io/gh/SCALE-MS/scale-ms/pull/361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=SCALE-MS#diff-c3JjL3NjYWxlbXMvcmFkaWNhbC90YXNrLnB5) | `75.09% <75.09%> (ø)` | | | [src/scalems/radical/runtime.py](https://app.codecov.io/gh/SCALE-MS/scale-ms/pull/361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=SCALE-MS#diff-c3JjL3NjYWxlbXMvcmFkaWNhbC9ydW50aW1lLnB5) | `85.81% <76.19%> (+59.70%)` | :arrow_up: | | [src/scalems/radical/session.py](https://app.codecov.io/gh/SCALE-MS/scale-ms/pull/361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=SCALE-MS#diff-c3JjL3NjYWxlbXMvcmFkaWNhbC9zZXNzaW9uLnB5) | `77.50% <77.50%> (ø)` | | | [src/scalems/radical/raptor/\_\_init\_\_.py](https://app.codecov.io/gh/SCALE-MS/scale-ms/pull/361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=SCALE-MS#diff-c3JjL3NjYWxlbXMvcmFkaWNhbC9yYXB0b3IvX19pbml0X18ucHk=) | `87.34% <88.09%> (+38.70%)` | :arrow_up: | | [examples/basic\_pipeline/echo-pipeline.py](https://app.codecov.io/gh/SCALE-MS/scale-ms/pull/361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=SCALE-MS#diff-ZXhhbXBsZXMvYmFzaWNfcGlwZWxpbmUvZWNoby1waXBlbGluZS5weQ==) | `100.00% <100.00%> (ø)` | | | [src/scalems/invocation.py](https://app.codecov.io/gh/SCALE-MS/scale-ms/pull/361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=SCALE-MS#diff-c3JjL3NjYWxlbXMvaW52b2NhdGlvbi5weQ==) | `92.22% <100.00%> (+4.58%)` | :arrow_up: | | [src/scalems/radical/\_\_init\_\_.py](https://app.codecov.io/gh/SCALE-MS/scale-ms/pull/361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=SCALE-MS#diff-c3JjL3NjYWxlbXMvcmFkaWNhbC9fX2luaXRfXy5weQ==) | `100.00% <100.00%> (+7.69%)` | :arrow_up: | | [src/scalems/radical/exceptions.py](https://app.codecov.io/gh/SCALE-MS/scale-ms/pull/361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=SCALE-MS#diff-c3JjL3NjYWxlbXMvcmFkaWNhbC9leGNlcHRpb25zLnB5) | `100.00% <100.00%> (ø)` | | ... and [8 files with indirect coverage changes](https://app.codecov.io/gh/SCALE-MS/scale-ms/pull/361/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=SCALE-MS)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.