search

SCALE-MS / scale-ms

SCALE-MS design and development
GNU Lesser General Public License v2.1
4 stars 4 forks source link

De-noise. #368

Closed eirrgang closed 1 year ago

eirrgang commented 1 year ago

Significantly prune placeholders, stubs, speculative documentation, unused code, and irrelevant tests.

Remove the scalems.local backend and focus on the upcoming (#345) Raptor based function tasks.

There is no near-term utility for facilities limited to single-process or single-threaded tasks, and the RP backend does not work right with "local" (fork-based launchers).

eirrgang commented 1 year ago

I will probably make several incremental changes to focus the docs and testing while I unify code paths and focus on supporting the core use cases we are targeting for our minimum viable product. I may merge without waiting particularly long for review, but I invite feedback at any point, and the snapshots of changes and documentation builds (linked from the Checks below) may be useful to see what is changing.

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.30 :tada:

Comparison is base (bc88f48) 78.53% compared to head (0355a21) 78.83%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #368 +/- ## ========================================== + Coverage 78.53% 78.83% +0.30% ========================================== Files 36 32 -4 Lines 3987 3742 -245 Branches 608 574 -34 ========================================== - Hits 3131 2950 -181 + Misses 643 588 -55 + Partials 213 204 -9 ``` | [Impacted Files](https://app.codecov.io/gh/SCALE-MS/scale-ms/pull/368?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=SCALE-MS) | Coverage Δ | | |---|---|---| | [src/scalems/invocation.py](https://app.codecov.io/gh/SCALE-MS/scale-ms/pull/368?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=SCALE-MS#diff-c3JjL3NjYWxlbXMvaW52b2NhdGlvbi5weQ==) | `78.88% <ø> (-13.34%)` | :arrow_down: | | [src/scalems/messages.py](https://app.codecov.io/gh/SCALE-MS/scale-ms/pull/368?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=SCALE-MS#diff-c3JjL3NjYWxlbXMvbWVzc2FnZXMucHk=) | `87.50% <ø> (ø)` | | | [src/scalems/radical/runtime.py](https://app.codecov.io/gh/SCALE-MS/scale-ms/pull/368?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=SCALE-MS#diff-c3JjL3NjYWxlbXMvcmFkaWNhbC9ydW50aW1lLnB5) | `79.71% <ø> (ø)` | | | [src/scalems/radical/runtime\_configuration.py](https://app.codecov.io/gh/SCALE-MS/scale-ms/pull/368?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=SCALE-MS#diff-c3JjL3NjYWxlbXMvcmFkaWNhbC9ydW50aW1lX2NvbmZpZ3VyYXRpb24ucHk=) | `74.59% <ø> (ø)` | | | [src/scalems/radical/task.py](https://app.codecov.io/gh/SCALE-MS/scale-ms/pull/368?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=SCALE-MS#diff-c3JjL3NjYWxlbXMvcmFkaWNhbC90YXNrLnB5) | `74.91% <ø> (-0.36%)` | :arrow_down: | | [examples/basic/echo.py](https://app.codecov.io/gh/SCALE-MS/scale-ms/pull/368?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=SCALE-MS#diff-ZXhhbXBsZXMvYmFzaWMvZWNoby5weQ==) | `100.00% <100.00%> (ø)` | | ... and [2 files with indirect coverage changes](https://app.codecov.io/gh/SCALE-MS/scale-ms/pull/368/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=SCALE-MS)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.