search

SCBI-ForestGEO / McGregor_climate-sensitivity-variation

repository for linking the climate sensitity of tree growth (derived from cores) to functional traits
0 stars 0 forks source link

reconcile duplicate files for crown position data #1

Closed teixeirak closed 5 years ago

teixeirak commented 5 years ago

@mcgregorian1 @gonzalezeb

It looks like we've created two files for AJ's data: https://github.com/SCBI-ForestGEO/tree-growth-and-productivity/blob/master/dendro_cored_full/dendro_cored_full.csv (the one where data are being entered) https://github.com/SCBI-ForestGEO/SCBI-ForestGEO-Data/blob/master/tree_dimensions/tree_crown_position/scbi.crownposition.csv

Non-urgently, but not too long after AJ finishes (say by the end of Dec), let's reconcile those files. Let's have the official long-term master data file in SCBI-ForestGEO-Data/tree_dimensions.

mcgregorian1 commented 5 years ago

Whoops, that's my bad. I had forgotten I had made the crown.position csv when I was starting to enter data yesterday.

Which format do you prefer?

teixeirak commented 5 years ago

You can keep the first (more complete). Please be sure to indicate in the metadata when the census data (coordinates, dbh) were last updated.

mcgregorian1 commented 5 years ago

Ok. Currently the dendro_cored_full is in the "growth and productivity" folder. Did you want that moved to "tree dimensions"? I think this is why I created the other file initially.

gonzalezeb commented 5 years ago

I would like to see the 3 crown assessments in that file so we have all crown data in one single file. We also need to indicate the crown assessment date. I will check the file next week.

Sent from my iPhone

On Nov 16, 2018, at 4:03 PM, Kristina Anderson-Teixeira notifications@github.com<mailto:notifications@github.com> wrote:

You can keep the first (more complete). Please be sure to indicate in the metadata when the census data (coordinates, dbh) were last updated.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/SCBI-ForestGEO/tree-growth-and-productivity/issues/1#issuecomment-439526530, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AZoLNBijtAeRjb8iKDyapKTX0W8zc5V4ks5uvygfgaJpZM4Ym7un.

teixeirak commented 5 years ago

We created the growth and productivity folder for your analysis (although it now seems your main focus will be on growth and traits). I'd had in mind that this would combine merged files with growth data from both cores and dendro bands. We probably will want to pull the canopy position in for analysis in this repository, but the data master should stay in the data folder. (This is dividing "data production" and "data analysis").

mcgregorian1 commented 5 years ago

Ok. If I'm understanding you correctly, I should move dendro_cored_full to the "tree dimensions" folder, with the expectation I'll be using a table containing only the canopy position/crown assessments in the "growth and traits" folder, for my analyses.

I'll wait until next week to make any definitive changes.

teixeirak commented 5 years ago

Sounds good. We can clarify any smaller questions later.

mcgregorian1 commented 5 years ago

Ok. These are the changes I've made (I've also noted these in the commit as well). Let me know if you think this should be changed.

  1. dendro_cored_full was moved to tree dimensions and put in a folder called tree_crown_cored_geo. This replaces the tree_crownposition folder since dendro_cored_full has those measurements.

  2. tree-growth-and-productivity has been renamed tree-growth-and-traits. I've moved the (basic) Rscript here for subsetting dendro_cored_full so that way things are ready for when I want to create a table with just the crown assessments. I deleted the sample csv I made a couple weeks ago because it's not relevant anymore.

  3. I've updated the READMEs for each folder to reflect what's in them.

  4. I updated metadata for dendro_cored_full to say date of last udpate for geographic coordinates.

teixeirak commented 5 years ago

Thanks!

Please name this folder something more generic and intuitive like "crowns", then specify in the metadata which trees are (currently) included. Note that we have other crown data from dendro bands and mort survey that we'll want to pull into this folder (ideally in time to facilitate Aj's analysis).

gonzalezeb commented 5 years ago

There is crown folder already, why to create another one?

Sent from my iPhone

On Nov 20, 2018, at 5:37 AM, Kristina Anderson-Teixeira notifications@github.com<mailto:notifications@github.com> wrote:

Thanks!

Please name this folder something more generic and intuitive like "crowns", then specify in the metadata which trees are (currently) included. Note that we have other crown data from dendro bands and mort survey that we'll want to pull into this folder (ideally in time to facilitate Aj's analysis).

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/SCBI-ForestGEO/tree-growth-and-traits/issues/1#issuecomment-440225646, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AZoLNK28Z4XLlBbIt8BtAXXYHjcGYKpLks5uw9tDgaJpZM4Ym7un.

gonzalezeb commented 5 years ago

Call it tree_crown.

Cuidado! Do not replace data with new data just because they are the same trees; the crown data there was from previous years.

On Nov 19, 2018, at 8:56 AM, Ian McGregor notifications@github.com<mailto:notifications@github.com> wrote:

Ok. These are the changes I've made (I've also noted these in the commit as well). Let me know if you think this should be changed.

  1. dendro_cored_full was moved to tree dimensionshttps://github.com/SCBI-ForestGEO/SCBI-ForestGEO-Data/tree/master/tree_dimensions and put in a folder called tree_crown_cored_geo. This replaces the tree_crownposition folder since dendro_cored_full has those measurements.

  2. tree-growth-and-productivity has been renamed tree-growth-and-traits. I've moved the (basic) Rscript here for subsetting dendro_cored_full so that way things are ready for when I want to create a table with just the crown assessments. I deleted the sample csv I made a couple weeks ago because it's not relevant anymore.

  3. I've updated the READMEs for each folder to reflect what's in them.

  4. I updated metadata for dendro_cored_full to say date of last udpate for geographic coordinates.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/SCBI-ForestGEO/tree-growth-and-productivity/issues/1#issuecomment-439900743, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AZoLNIH8_rOPSgOMV8c25wtsZrzXT_jYks5uwriUgaJpZM4Ym7un.

mcgregorian1 commented 5 years ago

The folder is now tree_crown.

Agreed. Dendro_cored_full specifically has only the new crown measurements. The crown data from previous years is preserved in the dendroband archive data / each year's master's.

teixeirak commented 5 years ago

I created a new copy of the tree-growth-and-productivity repository, as I do want to keep that even though its not your focal project. Could you please save the code there?

mcgregorian1 commented 5 years ago

@teixeirak did you want have multiple copies of the script? As in, did you want to have the script in tree-growth-and-traits (for my project) and again in tree-growth-and-productivity?

Also, something is off with the repositories. Github desktop thinks that the tree-growth-and-productivity repo is the same as the tree-growth-and-traits. Did you change the name when you made the former or did you make a full new repository? When I clone both repos to Gtihub desktop, the files show up as being the exact same as what's currently in tree-growth-and-traits.

teixeirak commented 5 years ago

Just keep one copy (in this repo) for now. Closing this.