minor tasks for Ian from reviewers/ coauthors

SCBI-ForestGEO / McGregor_climate-sensitivity-variation

repository for linking the climate sensitity of tree growth (derived from cores) to functional traits

0 stars 0 forks source link

minor tasks for Ian from reviewers/ coauthors #116

Closed teixeirak closed 4 years ago

teixeirak commented 4 years ago

[x] R4: Figure S1: please add spatial scale to the figure.
[x] R4: Table 3: are DBH units correct? I suspect they should be mm instead of cm. (they are in mm. convert to cm)

mcgregorian1 commented 4 years ago

[x] R4: Table 2: are DBH units correct? I suspect they should be mm instead of cm. (they are in mm. convert to cm)

@teixeirak do you know anything about this? We have some values in the table that don't have a standard deviation. When I run my code on its own, these values aren't there; instead they are NA because the hydraulic traits data is missing. Do you remember who put these values in? What do you want to do for addressing the lack of sd?

I checked past closed issues but didn't see anything.

mcgregorian1 commented 4 years ago

[ ] R4: Figure S1: please add spatial scale to the figure.

Ah also we have two Figure S1s in the folder. I'm assuming you're talking about the cored tree locations and not the basic ForestGEO plot?

teixeirak commented 4 years ago

yeah, there are some without all 3 samples. Just leave as is.

teixeirak commented 4 years ago

Ah also we have two Figure S1s in the folder. I'm assuming you're talking about the cored tree locations and not the basic ForestGEO plot?

correct.

mcgregorian1 commented 4 years ago

I don't have much creative leeway with the way I've made the plot but I think this works. Let me know if you want it changed.

I should mention was trying to get a grey box around the legend and it appears I'm incapable of doing so.

teixeirak commented 4 years ago

Looks fine, but something went wrong with saving it; the image in the repo is blank.

mcgregorian1 commented 4 years ago

Oops sorry. It's fixed now