search

SCBI-ForestGEO / McGregor_climate-sensitivity-variation

repository for linking the climate sensitity of tree growth (derived from cores) to functional traits
0 stars 0 forks source link

fill in Rc and Rs sample sizes in table 3 #139

Closed teixeirak closed 4 years ago

mcgregorian1 commented 4 years ago

Do you also want individual year counts for these? Currently there's no place in the table for them.

teixeirak commented 4 years ago

Hmmm... perhaps add columns for the other 2 metrics?

mcgregorian1 commented 4 years ago

Sure, I'll try that in a second once Fig. 4 is made

teixeirak commented 4 years ago

Thanks! We still need to fill out ring porosity same sizes.

mcgregorian1 commented 4 years ago

@teixeirak the current rp numbers for Rt sum to 617, which doesn't match the individual year or total numbers. Do you know what those numbers represent?

teixeirak commented 4 years ago

No idea! I believe you generated them at one point. Let’s start fresh.

mcgregorian1 commented 4 years ago

Ok. In that case how do you want to split that up? By the full table or by individual year? As Table 3 currently is formatted, I think if we wanted to show the rp categorization by year then we would need to change the formatting.

teixeirak commented 4 years ago

No, not by year. I guess it should be by full table, although that's a bit weird in that some most cores are counted 3x. Oh well....

mcgregorian1 commented 4 years ago

I can do the absolute representation value for the full table - I think that makes the most sense

mcgregorian1 commented 4 years ago

@teixeirak I had not been including "semi-ring" as an RP category, only "ring" or "diffuse". I will go ahead and add it - it won't change our final models because we're not considering RP to begin with. However, it does add an extra row in Tables S4/S5/S6/S7 and changes the dAICc for RP; here, the coefficient for D is 0, and SR (semi-ring) has a distinct number.

teixeirak commented 4 years ago

We were previously counting semi-ring in the D group. Let's continue to do that. It doesn't make sense to have a category with only one 1 species.

mcgregorian1 commented 4 years ago

Ok sounds good. For the categories then in Table 3, you have semi-ring along with diffuse and ring. Did you want to keep that there even though we don't use that categorization?

teixeirak commented 4 years ago

In table 3, we’re recording the actual xylem porosity type. For the statistical model, we group D and SR.

mcgregorian1 commented 4 years ago

Gotcha! I've fixed that and uploaded it

teixeirak commented 4 years ago

@mcgregorian1, I'm almost positive that you accidentally switched the sample sizes for D and SR categories. I fixed this (this commit), but please verify that this is now correct.

mcgregorian1 commented 4 years ago

Oops, sorry about that. Thanks for catching!