ring porosity change

[mcgregorian1]

Hi @teixeirak

I got your email and quickly ran with the change for semi-ring to be diffuse. When you do that, the main change (without me comparing all the coefficients) is that ring porosity shows up in all three individual drought years as a top variable.

I can get to changing ring porosity to ring later.

[mcgregorian1]

Ah ok I had some quick time. So overall,

currently, RP is a candidate trait only for 1999

change semi-ring to diffuse

RP becomes a candidate trait in 1966,1977,1999. No other candidate traits change.

changes semi-ring to ring

RP becomes candidate trait in 1977,1999. No other candidate traits change.

For both of these changes, the top models for each candidate year do change. If you want to know the exact differences I'm going to need to spend more time on that during the evening.

[teixeirak]

It would be helpful if you could generate the tables behind tables 4 and 5 for changing semi-ring to diffuse. I'd like to see what this does to the coefficients. Again, changing to diffuse is a priority.

[mcgregorian1]

I've done the diffuse change. Table 4 is manually updated, and Table 5 is the same as "tested_traits_best_coeff.csv" but with "-" instead of NA.

I've put the changes in a new branch called "diffuse."

I think that's all I can do today during the day at least.

[teixeirak]

Thanks! These results are mainly consistent with the previous, but make more sense/ are more consistent (in particular, TLP now has consistently negative effect). Let's stick with this. I'll merge this back to the main branch and work on updating tables/ text.