SCBI-ForestGEO / McGregor_climate-sensitivity-variation

repository for linking the climate sensitity of tree growth (derived from cores) to functional traits
0 stars 0 forks source link

remove/ de-emphasize single-variable tests? #74

Closed teixeirak closed 4 years ago

teixeirak commented 4 years ago

@mcgregorian1 and @ValentineHerr

@ValentineHerr commented:

"I think I don’t get why you are separating “univariate” and “multivariate” analysis. In other words, why would you look at the results of a univariate model if you know there are other variables that make that model better? You know that the sign of a coefficient can switch when you add another variable. It is not worth looking at that coefficient until you’ve found the best model. If you change that, you can get rid of Table4."

We obviously need to change the wording. "Univariate" refers to tests of one independent variable at a time, whereas "multivariate" referred to the models with all factors we believed would be important.

This is a potentially very important comment, and I'm thinking it through... My initial response is that Table 4 plays some important roles, but I'm open to being convinced otherwise. In my mind, Table 4 has the following roles:

@ValentineHerr, do you still think Table 4 is superfluous?

ValentineHerr commented 4 years ago

Trying to answer each bullet points bellow. Let me know if that helps or if you think I am looking at it in the wrong way. If that is the case we can talk on the phone and see where things can be made more clear in the manuscript so that there is no confusion about what you tried to do.

We obviously need to change the wording.

Yes, it might be what is throwing me off, but if you are looking at several variables in your "univariate" approach then I don't understand the difference with your "multivariate" approach.

  • provides individual tests of the significance of variables (confirms their significance and direction in isolation, thereby ensuring that their presence in top models is justifies)

--> I disagree with this approach unless you don't have enough data to look at more than one variable at a time. The only thing you are testing by looking at one variable at a time is "is variable X the only variable driving Y?". Remember that the direction of a coefficient can flip when adding other important variables and this is very likely to happen if that other variable is correlated with the first one, which seems to be the case with CP and H. So I would never discuss the sign of a coefficient for a less than optimal model, and it is actually wrong to do so if two correlated variables are included in that model.

  • Identifies variables worth including in subsequent models, while testing predictions on others that don't make the cut for the top models (e.g., WD, SLA)

--> to me this is an exploratory phase that you do on your own but it does not have its place in a manuscript. To me, unless you need to pick what variable among 2 correlated variables you want to move on with, you don't need to do this since the multivariate model selection approach would get rid of variables that are not important.

  • Compares relative importance of different variables (e.g., height vs canopy position; canopy position with and without height in model)

--> I don't understand how table 4 would show that. if you want to look at relative importance of different variable you could try other options like:

@ValentineHerr, do you still think Table 4 is superfluous?

--> Probably yes. I think it is a useful table for you, in your exploratory phase, to get a feel for what is going on and maybe to select a sub-sample of variables to test in your multivariate analysis (if you had too many to look at and/for had collinearity among them). But I don't think it has it place in a manuscript. Table 4 looks quite confusing to me regardless. I think you forgot to define what dAICc is in the manuscript. Also, what is "Y" in the null variable column? drought year? if yes, maybe you should also call it "Y" in the column "variable". If you keep it, you need to help the reader more in the legend.

mcgregorian1 commented 4 years ago

Sorry this term is annoyingly busy but I will make sure to look at this on the weekend.

teixeirak commented 4 years ago

@ValentineHerr, thanks for the feedback. I'd like to talk about this with you in person tomorrow.

teixeirak commented 4 years ago

From in-person discussion, we determined that there's no need that what we've done basically makes sense, but we need to do some things to make it less confusing.

In Table 4:

teixeirak commented 4 years ago

@ValentineHerr, I'd appreciate it if you could look at the new version of table 4 and see if it looks good now, paying special attention to the legend. Would it be more intuitive to flip the sign convention on dAICc?

teixeirak commented 4 years ago

Table 4 should be good now. I've moved the uncompleted items above to issue #62 and will close this one.

teixeirak commented 4 years ago

I'm reopening this because of a comment from R1:

"The authors might like to consider including Table 4 as a supplement, because as it stands it looks like an exploratory analysis. If the ‘single-variable approach’ is not just exploratory, state it clearly and why it is needed besides the full models with several parameters."

teixeirak commented 4 years ago

This is now covered in issue #95, so I'll close it here.