SCBI-ForestGEO / McGregor_climate-sensitivity-variation

repository for linking the climate sensitity of tree growth (derived from cores) to functional traits
0 stars 0 forks source link

fix up citations #78

Closed teixeirak closed 4 years ago

teixeirak commented 4 years ago

@mcgregorian1,

(PLAdry; (Scoffoni et al., 2014))

(e.g., Lloret et al. (2011); D’Orangeville et al. (2018))

mcgregorian1 commented 4 years ago

@teixeirak which references need to be added?

teixeirak commented 4 years ago

If you look in the .Rmd file, you'll see some that I put in with links to the articles.

mcgregorian1 commented 4 years ago

Ah ok. I'll get to those soon

On Mon, Mar 2, 2020 at 10:21 AM Kristina Anderson-Teixeira < notifications@github.com> wrote:

If you look in the .Rmd file, you'll see some that I put in with links to the articles.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/SCBI-ForestGEO/McGregor_climate-sensitivity-variation/issues/78?email_source=notifications&email_token=AJNRBEP24U44ICPDBQRPKSTRFPFHRA5CNFSM4KYR6MKKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOENPWSEI#issuecomment-593455377, or unsubscribe https://github.com/notifications/unsubscribe-auth/AJNRBEIFWQNBQ5JEHXSFDF3RFPFHRANCNFSM4KYR6MKA .

--

Ian McGregor

Ph.D. Student | Center for Geospatial Analytics

He/Him/His

College of Natural Resources

Jordan Hall 4120 | Campus Box 7106

North Carolina State University

2800 Faucette Dr.

Raleigh, NC 27695 USA imcgreg@ncsu.edu | 714-864-1005 | geospatial.ncsu.edu

mcgregorian1 commented 4 years ago

Did you want this to be cited or just mentioning the website? It's an odd site for citation.

"PDSI divisional data for Northern Virginia were obtained from NOAA (https://www7.ncdc.noaa.gov/CDO/CDODivisionalSelect.jsp) in December 2017."

mcgregorian1 commented 4 years ago

Line 154 in the main .Rmd file:

"...with static versions corresponding to data and analyses presented here archived in Zenodo (DOIs: 10.5281/zenodo.3604993 and [TBD], respectively krista just to remind you this TBD is here)."

When I went to this site for zenodo it takes me to an update page. I'm not sure which specific link you wanted here.

teixeirak commented 4 years ago

Did you want this to be cited or just mentioning the website? It's an odd site for citation.

"PDSI divisional data for Northern Virginia were obtained from NOAA (https://www7.ncdc.noaa.gov/CDO/CDODivisionalSelect.jsp) in December 2017."

I think its fine as is.

mcgregorian1 commented 4 years ago

Cool. This is done for now until we add more

teixeirak commented 4 years ago

I think we're

* citations aren't rendered appropriately when enclosed in parentheses with other content:

@mcgregorian1, these examples are still an issue. For the examples above, we'd want:

(PLAdry; Scoffoni et al., 2014)

(e.g., Lloret et al. 2011; D’Orangeville et al. 2018)

That is, we don't want parentheses within parentheses. I'll see if I can find a fast solution, but if not I don't think its worth holding up the submission.

mcgregorian1 commented 4 years ago

I see what you mean. In markdown if you have [@citation], the brackets serve as the parentheses. I can change these quickly.

mcgregorian1 commented 4 years ago

Ok I just fixed the Scoffoni but the d'orangeville reference isn't showing up at all when I search the text

teixeirak commented 4 years ago

Hold on-- I'm working on it right now too. I just pushed the latest, but think you'll have a conflicted copy.

mcgregorian1 commented 4 years ago

no worries, i just pushed

teixeirak commented 4 years ago

This actually doesn't get what I was hoping. It gives (PLAdry; Scoffoni et al. (2014)).

I'm hoping to get (PLAdry; Scoffoni et al. 2014). (no parentheses around year)

Do you know a way to do that?

mcgregorian1 commented 4 years ago

Yeah I noticed that. I think with the way that markdown formats things, it's unavoidable unless we hand-type the reference. If we do this, however, it will not link to the references section.

teixeirak commented 4 years ago

It's not a big deal. We can leave it as is for now, and the journal will fix it up in the publication process anyway.