SCBI-ForestGEO / SCBI-ForestGEO-Data

Public data repository of the SCBI ForestGEO plot
https://scbi-forestgeo.github.io/SCBI-ForestGEO-Data/
Creative Commons Attribution 4.0 International
7 stars 7 forks source link

Review Mortality 2020 data #26

Closed gonzalezeb closed 4 years ago

gonzalezeb commented 4 years ago

Hi @camerondow35, this is for you to review..let me know if you have questions..

Problems founds in Mortality_Survey_2020_csv

Others: After all coring is done you need to indicate in the datasheet if ‘cored’=yes or no (column AE).

About data folder: All files produced with the r script 1-Creating_data_files_from_raw_data.R, have same length (13370 observations) but mortality_2020 has 72555 obs. Please check the code, there must be something wrong there..

camerondow35 commented 4 years ago

More than 1800 records have no date or surveyor

The only records w/o dates are PD, am I supposed to put a date for those too?

Tag 30001: was DC in 2019, now is DS. It has same comment as last year. Should be PD. Tag 12271, was DS last year. Should be PD

Mistakes - fixed.

Why some NOT Fraxinus trees that are Alive have ‘crown.position’ information? Multiples species have that info, in total 22 trees, why?.

Ah, they were AU last year and I forgot to delete the crown position. Fixed.

Frpe 123412 and fram 133706 are missing crown.position

Judging by dbh 2018 and quadrats they were in, I assigned them both S

For some comments you wrote XX% whitening? What does it mean “whitening”? getting white? I have no idea what it means.

% whiteneing refers to EAB whitening. It's the same comments Alyssa used last year. Remove?

camerondow35 commented 4 years ago

About data folder: All files produced with the r script 1-Creating_data_files_from_raw_data.R, have same length (13370 observations) but mortality_2020 has 72555 obs. Please check the code, there must be something wrong there..

For some reason all of mine had 75526...I'll try rerunning the script now that theyre reverted to the originals but there were parts of it I don't understand

camerondow35 commented 4 years ago

Ran the script and pushed the result. Now has 13380...

gonzalezeb commented 4 years ago

answers to your questions @camerondow35

More than 1800 records have no date or surveyor The only records w/o dates are PD, am I supposed to put a date for those too?

Yes, they should have the same date when you visit that quadrat.

For some comments you wrote XX% whitening? What does it mean “whitening”? getting white? I have no idea what it means. % whiteneing refers to EAB whitening. It's the same comments Alyssa used last year. Remove?

That term "EAB whitening" is not in the literature. What does it means to you? I think Alyssa meant "20% bark flaking" . When the bark is removed by woodpeckers on a damaged tree (while searching for EAB larvae) the inner bark will get lighter. I think that's the reason why she came with that term. But we don't have to repeat it. Tell me what did you mean with that and then we can make a decision to change the term in 2020.

camerondow35 commented 4 years ago

OK would you like me to add dates based on the quadrat survey date or shall I just add one date for all PD?

Yes, whitening refers to the EAB code W: bark blonding. I see in 2018 % was not noted in cases of W. I feel like 'whitening' is intuitive to me, since the code is a W. It might be confusing to use whitening for 2019 then change it in 2020, no?

gonzalezeb commented 4 years ago

OK would you like me to add dates based on the quadrat survey date or shall I just add one date for all PD?

they should have the same date when you visit that quadrat (based on the quadrat survey date)

Yes, whitening refers to the EAB code W: bark blonding. I see in 2018 % was not noted in cases of W. I feel like 'whitening' is intuitive to me, since the code is a W. It might be confusing to use whitening for 2019 then change it in 2020, no?

Nope. Whitening is not a term related to EAB infection, and the 'W" was establish to refere to "Woodpecker" not "whitening" so let's don't repeat the mistake as 2019. Please replace by bark blonding in your comments.

camerondow35 commented 4 years ago

Nope. Whitening is not a term related to EAB infection, and the 'W" was establish to refere to "Woodpecker" not "whitening" so let's don't repeat the mistake as 2019. Please replace by bark blonding in your comments.

Should I replace it in 2019 as well, while im at it?

camerondow35 commented 4 years ago

For the dates I just used this code for(i in 1:nrow(Mortality_Survey_2020)){ Mortality_Survey_2020[i,32] <- ifelse(is.na(Mortality_Survey_2020[i,32]), Mortality_Survey_2020[(i-1),32], Mortality_Survey_2020[i,32]) } While likely not 100% accurate, i think this is the most efficient way of doing it.

gonzalezeb commented 4 years ago

sure for both

camerondow35 commented 4 years ago

ok, pushed to github.