SCBI-ForestGEO / SCBI-ForestGEO-Data

Public data repository of the SCBI ForestGEO plot
https://scbi-forestgeo.github.io/SCBI-ForestGEO-Data/
Creative Commons Attribution 4.0 International
7 stars 7 forks source link

Question for which cores to use #4

Closed mcgregorian1 closed 5 years ago

mcgregorian1 commented 5 years ago
  1. The graph in the pdf has been updated to include both alive trees and dead trees that were recorded as having a dbh > 0 in this past census.
  1. You asked me to make a table of the number of cored trees by crown class. To do this, I simply need to find the tag numbers of cored trees and make a subset of our dendro_cored_full.
teixeirak commented 5 years ago
  1. I'm confused as to when these trees with zero dbh died/ why they got canopy position but not DBH recorded. We must have a past dbh for them, and that can be used in place of dbh=0.
  2. Yes, please do make that change-- for this particular analysis, where we're only interested in classifying the cores that can be used for your analysis. It will also be valuable to put all data into constructing a model to predict most likely canopy position by DBH and maybe species (as AJ is working on), but that won't be needed for your analysis.
mcgregorian1 commented 5 years ago
  1. Yes, we have the dbh from the 2013 census; we recorded them dead in this year's census. I can assign them the 2013 dbh then.

  2. Sounds good; I can do this.

mcgregorian1 commented 5 years ago

@RHelcoski I'm tagging you just so you're aware.

@teixeirak I'm going through to complete step 2 (above), and I noticed there were some duplicates in the cores we used for Ryan's analysis. Specifically, the following:

90552 - it is in both cato and caovl chronologies. In 2018 census it is set as caovl. I've compared the two chronologies, and since they are identical, I've deleted the data from cato.

30567 - there is both an A and B cagl chronology. I'm noting this because this was still included in the cores run for Ryan's analysis, though I thought you had only wanted to process the A cores (according to Ryan's new metadata)? I'm assuming for my analysis when sending to Neil I'd only send the A chronology?

172210 - cagl same thing as for 30567 above 92183 - cagl same thing as for 30567 above

small fix

Ryan - in chronology_list, the "num_individual" column is sometimes right and sometimes a little off, based on the rows in the the csv files in current_chronologies. I'm going through and fixing those numbers for all of them.

current status

The graphs are updated to include only the specific individuals that were included in Ryan's analysis. Next step is to assign the numbers per canopy class.

An explanation of the different subsetting done to get the graphs is included as "DBH_CrownPosition_description.md" in the tree_crowns folder.

RHelcoski commented 5 years ago

Hey Ian, these were all changes that were made previously. Are you sure you didn't make edits to archived files? (The small fixings)

RHelcoski commented 5 years ago

I'm referring to this section: "90552 - it is in both cato and caovl chronologies. In 2018 census it is set as caovl. I've compared the two chronologies, and since they are identical, I've deleted the data from cato.

30567 - there is both an A and B cagl chronology. I'm noting this because this was still included in the cores run for Ryan's analysis, though I thought you had only wanted to process the A cores (according to Ryan's new metadata)? I'm assuming for my analysis when sending to Neil I'd only send the A chronology?

should this is be fixed for Valentine's code to run on again? 172210 - cagl same thing as for 30567 above 92183 - cagl same thing as for 30567 above"

RHelcoski commented 5 years ago

Check \Dropbox (Smithsonian)\climate sensitivity\results\z_FinalChronologies, these are the actual files that Valentine used and I don't see any B cores nor do I see the core issues you mentioned

teixeirak commented 5 years ago

I'm very glad to hear this! Let's replace the final chronologies in this repository with the correct one.

mcgregorian1 commented 5 years ago

Ok, sounds good. I'll just update the rwl and csv files in current_chronologies. Thanks Ryan!

RHelcoski commented 5 years ago

No problem, I'm glad you tagged me. It can get complicated with so many versions of this data floating around.

mcgregorian1 commented 5 years ago

@teixeirak everything is uploaded to github (along with a clearer graph) here

mcgregorian1 commented 5 years ago

I think things are fine with this issue, so I'm going to close it.