check / revise tests

[teixeirak]

@emacmonigle and @ValentineHerr ,

We currently have a long list of field-fix errors, but I believe a lot of them are not really errors. For example, we have errors generated for missing crown position on previously dead trees (do we need that, @djj4tree? Seems like we can skip it after the first year dead):

[djj4tree]

Crown position if it is still standing maybe helpful for vlassifying aerial imagery. We are collecting crown position on every standing tree. The decay of crowns might be interesting.

On Fri, Jun 3, 2022, 12:07 AM Kristina Anderson-Teixeira < @.***> wrote:

@emacmonigle https://github.com/emacmonigle and @ValentineHerr https://github.com/ValentineHerr ,

We currently have a long list of field-fix errors, but I believe a lot of them are not really errors. For example, we have errors generated for missing crown position on previously dead trees (do we need that, @djj4tree https://github.com/djj4tree? Seems like we can skip it after the first year dead):

[image: image] https://user-images.githubusercontent.com/6355854/171746181-478b17b0-ed3d-43a2-9bc3-55895b9ad3c6.png

— Reply to this email directly, view it on GitHub https://github.com/SCBI-ForestGEO/SCBImortality/issues/85, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADK3BJOVYBYVUOEZOWUPFD3VNEWCPANCNFSM5XWMXHWQ . You are receiving this because you were mentioned.Message ID: @.***>

[emacmonigle]

@jess-shue Since we want to record crow position and dead crown position, can we change the FFF since the option to record crown position is not always available for DS trees because of reasons discussed in issue #81. Thanks!

[teixeirak]

Okay, we have an inconsistency. @djj4tree , we've missed recording crown position on DS trees so far. I agree there's some value to continuing to monitor their crown position, but I'm not sure it would be worthwhile to go back and get all the missed trees. Do you have any objection to skipping it on the trees censused so far?

[jess-shue]

@emacmonigle OK, it should have still been there, just wasn't required, correct? It isn't that the field disappears...

I'm fighting with some of the other edits currently and will make sure crown position and dead crown position are available and required for DS trees.

[teixeirak]

Having not heard an opinion from @djj4tree , I'm going to go ahead and make a call on this one. I don't think it's worth returning to all the previously dead trees that are still standing to get crown position. @emacmonigle , can you please work with @ValentineHerr to create an exception in our tests so that these are removed from the list of errors?

[djj4tree]

I thought I commented? It would be a shame to have incomplete data. How many trees would have to revisited?

[jess-shue]

@teixeirak @djj4tree I have not completed some data checks (from dendro/census data) and some dendrometer band removals. I could schedule a day to come out and work on those and include checks of the missed trees if you have a list.

[teixeirak]

@djj4tree , I think it's on the order of ~30-40 trees, or a couple weeks worth of quadrats censused.

How about if we save these for the end of the year and return to them if time permits? It's obviously more important to finish the census than to have crown position on all previously dead trees. Crown position does not change quickly (and differences in how different surveyors classify it are probably greater than these changes), so I don't think it would significantly hurt analyses to assume that it remained unchanged from last year.

[djj4tree]

That doesnt sound like it should take long to visit 40 trees. Maybe Jess can clean then up when she is there.

[emacmonigle]

@jess-shue To confirm, the FFF actually does not give an option to record crow position AND dead crow position on DS/PD trees, but per @djj4tree's comments, I've been recording the crown position in the notes of such trees.

@teixeirak I wouldn't mind going back to resurvey needed trees, but I would be great to have some help in the field since my trip is coming up soon and I'm trying to make good progress on completing the survey before my class.

[jess-shue]

@emacmonigle It should give crown position and dead crown position. Do you not see both when using the app? It should be on Version 16 and required. Photos attached for what you should see. For DC and DN Crown position is no longer required and for DN the Dead crown position and Dead DBH are hidden. :

[emacmonigle]

@jess-shue The forms I was using this week were version 7, and didn't auto update when connected to wifi. Is there an extra step to pull the most recent updated forms? I may have missed that step.

I will try again Monday and let you know if I'm having trouble getting the most updated form.

[jess-shue]

Ah, sorry @emacmonigle I thought we had communicated that they need to be updated the other week. You need to be logged into the app and connected to WiFi for the form to update. You should see a spinning dial for a moment and message that it was updating. Have you been able to download the data OK? When the app has been updated but data is collected in an older version of the app on the iPad we can have problems downloading the data. Please let me know.

[emacmonigle]

@jess-shue Brought the iPad online today and confirming that the FFF updated to version 16.

I have an unfinished form in version 7, should I complete that or will version 7 forms cause an error? No worries if I need to redo, its only about 14 stems.

[jess-shue]

@emacmonigle Instead of re-doing them in the field, you could use a second iPad to re-enter the data by copying it from the V7 form - have the second iPad open on V16 and open your 'In Progress' V7. Go through each stem and add the data to the V16 - use that iPad to complete the quadrat. This will be the best way to assure no issues occur!

[djj4tree]

How many standing dead trees have you already done? It would be a shame to have incomplete data. Looking at the most recent data on it appears that there are only 12 trees that were DS in 2021 that were coded as DS in 2022 that have been censused so far.

On Fri, Jun 3, 2022 at 12:26 PM Kristina Anderson-Teixeira < @.***> wrote:

Okay, we have an inconsistency. @djj4tree https://github.com/djj4tree , we've missed recording crown position on DS trees so far. I agree there's some value to continuing to monitor their crown position, but I'm not sure it would be worthwhile to go back and get all the missed trees. Do you have any objection to skipping it on the trees censused so far?

— Reply to this email directly, view it on GitHub https://github.com/SCBI-ForestGEO/SCBImortality/issues/85#issuecomment-1146153018, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADK3BJOW7O7QD6WHHNODSTLVNIW33ANCNFSM5XWMXHWQ . You are receiving this because you were mentioned.Message ID: @.***>

[emacmonigle]

Hi Jess,

I haven't had any problems downloading the data! When I upload data from the iPad I am already logged onto FF and connected to wifi, but from there it has not updated yet.

Thanks, Erin

On Sun, Jun 12, 2022 at 9:28 AM, jess-shue @.***> wrote:

Ah, sorry @emacmonigle https://github.com/emacmonigle I thought we had communicated that they need to be updated the other week. You need to be logged into the app and connected to WiFi for the form to update. You should see a spinning dial for a moment and message that it was updating. Have you been able to download the data OK? When the app has been updated but data is collected in an older version of the app on the iPad we can have problems downloading the data. Please let me know.

— Reply to this email directly, view it on GitHub https://github.com/SCBI-ForestGEO/SCBImortality/issues/85#issuecomment-1153167818, or unsubscribe https://github.com/notifications/unsubscribe-auth/AYVHJF2JCGY7JHEJXMNFGQDVOXQXNANCNFSM5XWMXHWQ . You are receiving this because you were mentioned.Message ID: @.***>

-- Thanks, Erin MacMonigle

George Mason University Honors College

B.S., Environmental Science | Class of 2023

@.***

[teixeirak]

I think we can close this.