search

SCCapstone / Delta

A file transfer system for researchers to upload and share data sets with other researchers.
0 stars 0 forks source link

Quality Assurance: Unnecessary post requests #465

Closed jackcoberman closed 1 year ago

jackcoberman commented 1 year ago

It doesn't necessarily break anything, but: When the button "register" is clicked from the top right we are getting a failed post request. I think it would make sense for this button to only be a navigation button (thus not entailing a post request) or, if it must try to actually post to the database, for it to follow the same functionality as the actual register button (which will not make the post request until all fields are filled in correctly). image

lxaw commented 1 year ago

@jackcoberman Thank you for the find. Will look into it.

lxaw commented 1 year ago

This was actually a pretty interesting insight; so in the way we set things up, in order to register you have to be sure that you no longer are logged in / have a token stored in your local storage (if you have a token then you would be authenticated and be able to log in). To destroy the token, the logout POST request is done. Sorry for the confusion!