search

SCCapstone / I_Spy_A-Eye

https://sccapstone.github.io/I_Spy_A-Eye/
3 stars 0 forks source link

allows symbols in card number and security code as well as number/ symbols in the name field #166

Closed Clmeyers-Dev closed 1 year ago

Clmeyers-Dev commented 1 year ago

image image

M-Valentino commented 1 year ago

Did you copy and paste symbols into the security code and card number fields? I want to be sure the numeric keyboard is working.

M-Valentino commented 1 year ago

I was doing some research on what characters are possible in card names, and they can include punctuation symbols, as well as numbers. No Unicode is allowed. Lowercase characters are also not allowed but an imaginary API that handles bank transactions could convert names to all uppercase on the API's end. It would be difficult for the user to only be allowed to input uppercase letters.

https://en.wikipedia.org/wiki/ISO/IEC_7813

Apparently it is legal to have a name contain a number in some states, such as Elon Musk's baby. Prince was even legally allowed to change his name to just a symbol. With all of that said, I added card name validation that detects if the user did not enter in ASCII characters (non extended version). It would not be a good idea to remove number and symbol acceptance from the name field.

I added validations to check if card numbers and security codes are all digits.