SCCapstone / PalmettoProgrammers

https://www.forces-unite.com
MIT License
4 stars 1 forks source link

Limit Number of Tags #548

Closed Jackson-Williams-15 closed 5 months ago

Jackson-Williams-15 commented 5 months ago

This only allows 6 tags to be selected, @epadams suggested we do 3 character tags only, which i think is fine. Alternatively we could keep the amount of characters the same as we have it now, but limit the amount to tags to 3.

epadams commented 5 months ago

Need more opinions before we limit the characters to a certain length, 3 might be too short. Things like "casual" or "strategy" are longer but probably would be commonly used. I do think we should set an overall limit though, not sure if this has been done in the API yet. We don't want 50 character length tags. I think the best options is to either limit the number of tags to 3/4, or expand the card width. @jbytes1027 @evan-scales @AaronKeys what do you think?

jbytes1027 commented 5 months ago

I think 4 tags =<10 characters each would work find and would probably fit.

AaronKeys commented 5 months ago

I think the 10-character limit is a good idea. Having 4 tags seems like a strange number to have. I think it should be 3 or 5, but if y'all want 4, that's fine with me.

epadams commented 5 months ago

Sounds good to me, I'll add that we should probably add the error props so that it looks consistent and gives an indication to the user what is wrong. Also will need to change the text included from #554 to match the new limit

Jackson-Williams-15 commented 5 months ago

I set the character limit to 10 and the overall limit to 4. I also added the error helpertexts.

https://github.com/SCCapstone/PalmettoProgrammers/assets/77497641/3ebec147-827c-4984-964e-f6f490aff5a9

@epadams @jbytes1027 @AaronKeys

epadams commented 5 months ago

looks really good, ill test it in a couple of minutes