search

SCCapstone / decision_maker

Mobile application for creating group events in a fair and all inclusive manner.
https://sccapstone.github.io/decision_maker/
5 stars 0 forks source link

No Save button, just save #347

Closed josemvidal closed 4 years ago

josemvidal commented 4 years ago

I add dexter to my group and it seems to work, until I go back to the main page and then back to the group settings and he is not there anymore:

2020-03-04_17-41-22 (1)

also, dexter's app still shows no group, even after pull-down-to-refresh

image

john-andrews12 commented 4 years ago

Hello @josemvidal, after you add 'Dexter' via the popup you get from hitting the 'Members' button, you will notice that the top right corner of the screen becomes a blue save button. You must click this save button so that your changes persist. Otherwise changes will be lost. Maybe we should add a confirm that makes sure the user wants to leave unsaved work to prevent this in the future.

josemvidal commented 4 years ago

Just get rid of the Save buttons. The rule is: no save buttons on phones (try to find a save button on any well-known app) because users can get interrupted at any time and have to turn off the phone or go to another app.

john-andrews12 commented 4 years ago

@josemvidal Currently, it would be very difficult for us to remove the save buttons. Our back end system is not designed to handle input that is constantly streamed into it. This type of design could produce a massive number of API calls. What if you miss type a username and didn't want to add that user to your group? What if you misenter a setting and that automatically propagates to all group members?

Our group models are the core to our apps functionality. If a user makes a lot of changes and decides the don't want to keep them, without a save button there would be no way to revert. The user would have to rely on memory at the best and at the worst the user could try to quickly close the app. Ultimately I think this type of design could lead to a worsened UX.

We have found numerous well known mobile apps that have a save button. Apps such as Expedia, Slack, Venmo (10,000,000+ installs according to Google Play), Amazon (100,000,000+ installs according to Google Play), GroupMe, AirBnb, Lyft, Bank of America, Uber, etc. We have attached several screen shots into a wiki page to help highlight the use of the save button in theses app.

josemvidal commented 4 years ago

See my gif above. You will save the moment the user clicks on the "Save User" button.

So, do the same thing you are doing now on the Save button, but on the Save User button.

joshrap67 commented 4 years ago

Implemented in (https://github.com/SCCapstone/decision_maker/pull/356)