search

SCCapstone / hackstreetboys

https://fridger.recipes
1 stars 0 forks source link

Ingredient page only shows 2, and they disappear when user clicks on sliders #189

Closed josemvidal closed 2 years ago

josemvidal commented 2 years ago

I added a bunch of ingredients (flour, egg) and they show up on My Pantry, but cannot get them to show on Ingredient page, because search is broken?

https://user-images.githubusercontent.com/228704/156059411-1e6e2026-3f65-4119-b5fe-6db336b3796a.mp4

afrederiksen commented 2 years ago

Try logging in again. I can see that the ingredient post requests were rejected due to authorization not being present. As a result of #188, JWT tokens necessary to perform POST, PUT, and DELETE calls expire after 15 minutes of provisioning. We'll increase this threshold in a later release.

qhnisbet commented 2 years ago

The search parameters are originally set to include all ingredients, but once the slider is clicked the max is currently being set to the current cursor placement which means that the maximum is set to the minimum which eliminates all results. The slider then needs to be moved to a higher position to change the maximum to include ingredients. In RC1 the filtering with be adjusted to make both knobs visible and properly positioned from the beginning. However the filtering does work properly right now, it's just an issue with the UI that isn't particularly obvious to the user which is causing the disappearing ingredients.

josemvidal commented 2 years ago

Yes, fix the default values so it works as the user expects.

qhnisbet commented 2 years ago

Issue fixed by setting default slider values to max default min/max.