search

SCCapstone / turn-based-rpg

5 stars 1 forks source link

Dialogue Boxes #117

Closed chris-moore-dev closed 8 months ago

chris-moore-dev commented 9 months ago

Players will be able to interact with NPCs and initiate dialogue, which will be displayed at the bottom of the screen. In some cases, players will be prompted to make a choice during dialogue, e.g., "ask about local rumors", "ask for directions to castle", or "leave".

josemvidal commented 8 months ago

This feature appears to be implemented. Why is this still open?

After you do and Issue, you close it, with a comment that points to the commit that closes it. In GitHub you can do this automatically by just writing "closes #xx" in the git-commit comment.

Please watch my teamwork lecture which explains all this an more.

josemvidal commented 8 months ago

Tip: When you close an issue by writing code, either fixing a bug or creating a new feature, you should add a link to the git-commit(s) that did it.

This can be done automatically if you just write "closes #X" in the comment of the git-commit or the pull request, where X is the issue number you want to close. See linking pull requests to issues using keywords for more information, or watch this video.

You should also write "#X" on any commit that is for #X. That commit will then get automatically linked to the Issue.

See my github tips list for all the tips.