MembershipForm Improvements - Githubissues

SCE-Development / Clark

Made entirely by SJSU students, this is the Software and Computer Engineering Society's outward face on the internet.

https://sce.sjsu.edu

MIT License

28 stars 11 forks source link

MembershipForm Improvements #1437

Open evanugarte opened 3 weeks ago

evanugarte commented 3 weeks ago

we should fix the below:

[ ] right now we are telling the user that a user name is taken if any error is returned from the backend. this error should only be shown if the api returned a409

https://github.com/SCE-Development/Clark/blob/bef547eee84d8f37c596bba7f73ecf177c35d820/src/Pages/MembershipApplication/MembershipForm.js#L231

[ ] remove all usages of this function, verification emails are now sent when a user signs up https://github.com/SCE-Development/Clark/blob/bef547eee84d8f37c596bba7f73ecf177c35d820/src/Pages/MembershipApplication/MembershipForm.js#L6

game plan

follow this wiki page https://github.com/SCE-Development/Clark/wiki/Getting-Started
create an account with the sce tool
run the website, create an account through the sign up page
try creating an account again with the same email, ensure the error appears for conflicting email
try to fix the above 2 things