search

SCECcode / awp

AWP with topography
BSD 3-Clause "New" or "Revised" License
1 stars 2 forks source link

Dev-issue9 #10

Closed hzfmer closed 5 years ago

hzfmer commented 5 years ago

Fix issue #9 . The _writegrid tool now accepts an input mesh_out to control whether to generate material property file.

ooreilly commented 5 years ago

So if we merge this then we will also merge the changes from #7 ? Ok with me, but I still would like to see that we resolve remaining tasks in #7.

hzfmer commented 5 years ago

I think it's fine to merge this first and then merge #7 , since @deanrockit is still working on #7 .

I kind of messed up the commit histories.. There is still a lot to learn about Git for me.

deanrockit commented 5 years ago

@ooreilly Which branch is going to be merged into which branch?

ooreilly commented 5 years ago

@deanrockit this PR right here, dev-issue9 -> master.

deanrockit commented 5 years ago

@ooreilly Got you. I think it's fine, since @hzfmer only modified the write grid tool and I won't do anything about it. Please do.