Fixes

[ooreilly]

This PR introduces the following fixes:

• Resolve #12
• Prevent DM sync issues by changing ngsl from 8 to 4
• Fix parallel inconsistency when force is applied at the interface of two mpi partitions

Recommendations: Please check that source propagates correctly across the DM overlap zone. Run two test simulations:

1. Place one source in the top block near the overlap zone.
2. Place one source in the bottom block near the overlap zone. Check that it in each case that waves can propagate across the overlap zone with causing numerical artifacts.

[hzfmer]

Yes, since the previous patch did fix the bug we found in Pull Request 13 (I have pushed it to the remote “fixes” branch (af2d0b48c)), we should run tests on this patch.

I have attached the script to set up the tests, and as I mentioned, inserting a few lines in “input/receiver.txt” should reproduce the problem.

Thanks, Zhifeng On Nov 23, 2020, 17:06 -0800, ooreilly notifications@github.com, wrote:

@ooreilly commented on this pull request. In src/mpi/distribute.c:

                 grid_numbers[i] == grid_number) {

• idx[j] = i;
• j++;
• printf("i = %ld found in block %d \n", i, grid_number);
• switch (mode) {
• case DIST_COUNT:
• nlocal++;
• break;
• case DIST_INSERT_INDICES:
• (*indices)[j] = i; Nice job reducing the problem down to a minimum example! I'm sorry but I don't have access to your test code anymore. Could you share it with me again please? you can email me. Also, do I need the latest changes we made to the code to reproduce the error? if so, please push them to this branch so that I can access them. Thanks. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe.

[ooreilly]

@hzfmer old link to your test code doesn't work anymore. I also don't see any attachments. Where should I look?