Set min-size on annotation pannel - Githubissues

SCENE-CE / mirador-annotation-editor

Apache License 2.0

5 stars 0 forks source link

Set min-size on annotation pannel #10

Open Drilio opened 7 months ago

Drilio commented 7 months ago

Set min-size on annotation pannel

Drilio commented 7 months ago

We can set minWidth to the annot' panel because this value is hardcoded there : https://github.com/SCENE-CE/mirador-video/blob/fbee524cc22ce67c29aa21efa91b58e811c762d3/src/components/CompanionWindow.js#L122

I don't understand why it's hardcoded there because it's also set in the theme there : https://github.com/SCENE-CE/mirador-video/blob/fbee524cc22ce67c29aa21efa91b58e811c762d3/src/config/settings.js#L207

And Rnd isn't a MUI component so I can override this value with theme.

I see 3 solutions there :

Ask Mirador to remove the hardcoded value so it only pass with CSS.
Wrap CompanionWindow with a plugin so we can change this value for our annotation panel only.
Applies CSS rules that don't break the content but hide it instead when panel size is less than 250px.