Some manifests cause crash

SCENE-CE / mirador-annotation-editor

Apache License 2.0

6 stars 0 forks source link

Open geourjoa opened 1 month ago

geourjoa commented 1 month ago

This manifest can break MAE only in beeing in the manifest catalog.

I think it is the old manifest format

To reproduce :

App crash on manifest.js L142

geourjoa commented 1 month ago

Bug come manifesto and IIIFResources.js

I dont know why error break mae and not Mirador Stock

geourjoa commented 1 month ago

I don't lose more time on it, I only remove this breaking manifest from default catalog.

daxid commented 1 month ago

Yes @geourjoa Lets keep this open and see if we figure out what's going on.

The Manifest is announced as using Presentation API v3 (the last) so it should not be considered as an "old" manifest.

Could the japanese characters inside it be the reason ?

geourjoa commented 1 week ago

I dont know why but now same error are now breaking mirador video

geourjoa commented 1 week ago

Ok, i have a lead

I downgrade manifesto.js 4.20.20 to 4.20.17 and it seem to work

geourjoa commented 1 week ago

I need also to force the addition of multiple package.

npm install react-sizeme
npm i @babel/plugin-proposal-private-property-in-object
npm i @babel/plugin-proposal-object-rest-spread
npm i

I use currently node 18 on this project

geourjoa commented 1 week ago