SCENE-CE / mirador-multi-user

1 stars 0 forks source link

POC fullstack #2

Closed geourjoa closed 1 month ago

geourjoa commented 2 months ago
Drilio commented 2 months ago

React Architectures propositions :

Drilio commented 2 months ago

I built the app with create-react-app but this is now deprecated and doesn't allow me to edit webpack.config easily, so I rebuild an app from scratch with Vite. This solved almost all of my problems.

Now I still have One problem. We didn't run 'npm build' before plushing the mirador-annotation-editor package, this is 'bad' practice and create errors with compilators such as webpack so I will build mirador-annotation-editor and retry

Drilio commented 2 months ago

I have two versions of the frontend

Drilio commented 2 months ago

Do we want to implement encryption for all of the user's data stored in data base ?

Drilio commented 2 months ago

Ressource for login routes in front : https://blog.logrocket.com/authentication-react-router-v6/

daxid commented 2 months ago

Do we want to implement encryption for all of the user's data stored in data base ?

@Drilio I think we don't. We don't need overkill security and confidentiality features. Just the standard good practices.

@geourjoa can you confirm ?

geourjoa commented 2 months ago

Yep no encryption except for password.

Drilio commented 2 months ago

30/04 TODO :

Drilio commented 2 months ago

@daxid @geourjoa, I just found a guide for implementing anti-brute force on login, do we want this ?

Drilio commented 2 months ago

I have an Issue with the way Mirador export workspace, this is not a valid JSON because at the beginning it's just an array of manifest. Here I had the key "some content" and it's working perfectly fine :

Image

daxid commented 2 months ago

On upstream Mirador https://mirador-dev.netlify.app/__tests__/integration/mirador/ the export is fine :

[Uploading mirador_export.json…]()

daxid commented 2 months ago

@daxid @geourjoa, I just found a guide for implementing anti-brute force on login, do we want this ?

Yes but it is not a priority. You must have a working demo first.

Please make a separate issue for this.

Drilio commented 2 months ago

We have a lot of "source map error", I look for this issue on the internet, I think it come from vite configuration in dev mode, we shouldn't have this errors on production, but I post this here so we know we have to check this : (The error doesn't cause any bug) Image