Address possible loss of data warnings

SCIInstitute / Cleaver

A MultiMaterial Tetrahedral Meshing Library and Application

https://cleaver.readthedocs.io

Other

40 stars 18 forks source link

Address possible loss of data warnings #107

Closed thewtex closed 3 years ago

thewtex commented 3 years ago

From Visual Studio, for example:

_deps\cleaver_lib-src\src\lib\cleaver\CleaverMesher.cpp(160): warning C4018: '<': signed/unsigned mismatch flag Build Log Line 24 Warning _deps\cleaver_lib-src\src\lib\cleaver\CleaverMesher.cpp(316): warning C4267: 'argument': conversion from 'size_t' to 'int', possible loss of data flag Build Log Line 25 Warning _deps\cleaver_lib-src\src\lib\cleaver\CleaverMesher.cpp(433): warning C4244: 'return': conversion from 'double' to 'float', possible loss of data

thewtex commented 3 years ago

Eventually (although it would take a big review / update) 64-bit integer based meshes should be supported. However, first we would likely want a mesh algorithm parallelization wizard, e.g. @wschroed, to add support for parallel processing.