SCIInstitute / Cleaver

A MultiMaterial Tetrahedral Meshing Library and Application
https://cleaver.readthedocs.io
Other
40 stars 18 forks source link

Meshes not right size, location, or value. #79

Closed bzenger closed 5 years ago

bzenger commented 5 years ago

Please follow these instructions for your issue to be worked on:

Description

The new version of cleaver is scaling and creating meshes not like the old version, and that do not match the original segmentation. This is not a simple "translation" problem but something much more significant. I am unaware of how to fix this or why it would be.

See in the screen shots attached below. Red is the old version of cleaver, blue is the new version of cleaver.

Also, the "foreground" mesh number is now set to 0 and the background is set to 1, which is annoying for our programs that use the old format. Archive.zip

image

Steps to Reproduce

I created a simple segmentation of a cylinder and meshed them with identical (default) settings of both cleaver versions.

Important notes:

  1. The cleaver loading of the file took much longer in the newer version than the older version. I am not sure why that would be. Cleaver also took significantly longer to mesh in the newer version than the older version. By significant I mean a difference of several minutes to create the mesh.
  2. Loaded these identical files in as .nrrd files of a segmentation
  3. Cleaved, meshed, and saved them out as .mat files for matlab (according to the viewer) This was all done in the GUI, not command line

Versions

Mac OS: 10.13.6 Cleaver Versions: 2.3.1 and 2.4 (latest master) ITK 4.13 QT5.9

allywarner commented 5 years ago

Should be fixed with with latest PR. Although, Cleaver is still running slower on OSX. Release to follow.