SCIInstitute / ITKCleaver

Wrapper for Cleaver to use as an ITK filter
https://itk-wasm-cleaver-typescript-docs.netlify.app/#/
MIT License
4 stars 4 forks source link

ENH: Update for ITK 5.3.0 #23

Closed thewtex closed 1 year ago

thewtex commented 1 year ago

Build against stable itk-5.3.0 (includes refined Dask support among many other improvements).

Uses the new ITK remote module GitHub Action.

dzenanz commented 1 year ago

Warnings for Mac: https://open.cdash.org/build/8326278/configure and https://open.cdash.org/viewBuildError.php?type=1&buildid=8326278. As these links will go out of date in a month, here is a copy-paste of the warning messages:

CMake Warning (dev) at /Users/runner/work/ITKCleaver/build/_deps/cleaver_lib-src/src/lib/cleaver/CMakeLists.txt:43 (option):
  Policy CMP0077 is not set: option() honors normal variables.  Run "cmake
  --help-policy CMP0077" for policy details.  Use the cmake_policy command to
  set the policy and suppress this warning.

  For compatibility with older versions of CMake, option is clearing the
  normal variable 'BUILD_SHARED_LIBS'.
This warning is for project developers.  Use -Wno-dev to suppress it.

and /Applications/Xcode_13.2.1.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: _deps/cleaver_lib-build/lib/cleaver/libitkcleaver-5.3.a(ScaledField.cpp.o) has no symbols.

thewtex commented 1 year ago

and /Applications/Xcode_13.2.1.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: _deps/cleaver_lib-build/lib/cleaver/libitkcleaver-5.3.a(ScaledField.cpp.o) has no symbols.

@tbirdso do we have a way to specify custom warning exceptions?:

        set(CTEST_CUSTOM_WARNING_EXCEPTION
          \${CTEST_CUSTOM_WARNING_EXCEPTION}
          # macOS Azure VM Warning
          "ld: warning: text-based stub file"
          "libcleaver.a.*has no symbols"
          "libitkcleaver.*has no symbols"
          )
tbirdso commented 1 year ago

do we have a way to specify custom warning exceptions?:

Hi @thewtex , I have proposed a change to allow this, would help to have your review: https://github.com/InsightSoftwareConsortium/ITKRemoteModuleBuildTestPackageAction/pull/27

thewtex commented 1 year ago

Resolves #22