search

SCIInstitute / SCIRun

SCIRun is a Problem Solving Environment, for modeling, simulation and visualization of scientific problems. This is version 5, the upgraded version of SCIRun v4.
http://scirun.org
Other
127 stars 71 forks source link

Clang-tidy modernization #2117

Open dcwhite opened 4 years ago

dcwhite commented 4 years ago

Super cool! Can it be fed into the clang-tidy GitHub action? I was just looking at that one today

Yup! On the clang-tidy documentation, it says we can set the flag --format-style='file' (literally 'file', not a placeholder), and it will find the .clang-format file in the closest parent folder.

Feel free to make any changes to the format file.

Also, clang-tidy has a feature that does a project-wide refactor if you have a compilation database, which I did manage to create with bear to get IDE features. Though it'd be nice to get the compilation database made without bear because it is not available on Windows and requires turning off System Integrity Protection in Mac OS. You also have to stop the build after externals are finished, go to the bin/SCIRun folder, then restart with bear. Do you know if there's a way to set a cmake flag only for building in bin/SCIRun?

Originally posted by @RubioJr9 in https://github.com/SCIInstitute/SCIRun/pull/2113#issuecomment-628323491

dcwhite commented 4 years ago

See other tagged issues: https://github.com/SCIInstitute/SCIRun/labels/C%2B%2B11%2F14

dcwhite commented 4 years ago

Resharper for C++ can handle most of these too, but costs money.

github-actions[bot] commented 3 years ago

This issue is stale because it has been open 240 days with no activity. Remove the stale label or comment, or this will be closed in 60 days.

dcwhite commented 3 years ago

I have Resharper now! I'll make a list of the most important ones here.