SCIInstitute / ShapeWorks

ShapeWorks
http://sciinstitute.github.io/ShapeWorks/
Other
104 stars 32 forks source link

remove testing results from code tree #1266

Open cchriste opened 3 years ago

cchriste commented 3 years ago

It's very distracting to have these results cluttering up the untracked files, often resulting in missed additions. Example:

$ git status
...
Untracked files:
  (use "git add <file>..." to include in what will be committed)
    Examples/Python/README.md
    Libs/Utils/EigenUtils.cpp
    Testing/data/1x2x2.tiff
    Testing/data/1x2x2_back.nrrd
    Testing/data/cutting_plane_multi/sphere10_DT.nrrd
    Testing/data/cutting_plane_multi/sphere20_DT.nrrd
    Testing/data/cutting_plane_multi/sphere30_DT.nrrd
    Testing/data/cutting_plane_multi/sphere40_DT.nrrd
    Testing/data/ellipsoid_05.ply
    Testing/data/fixed_domain/sphere10_DT.nrrd
    Testing/data/fixed_domain/sphere20_DT.nrrd
    Testing/data/fixed_domain/sphere30_DT.nrrd
    Testing/data/fixed_domain/sphere40_DT.nrrd
    Testing/data/fixed_mesh_domain/shape_models/
    Testing/data/sample_001.nrrd
    Testing/data/sample_001_back.dcm
    Testing/data/sphere/sphere10_DT.nrrd
    Testing/data/sphere/sphere20_DT.nrrd
    Testing/data/sphere/sphere30_DT.nrrd
    Testing/data/sphere/sphere40_DT.nrrd
    Testing/data/sphere_constraint/sphere10_DT.nrrd
    Testing/data/sphere_constraint/sphere20_DT.nrrd
    Testing/data/sphere_constraint/sphere30_DT.nrrd
    Testing/data/sphere_constraint/sphere40_DT.nrrd
    Testing/data/use_normals/sphere10_DT.nrrd
    Testing/data/use_normals/sphere20_DT.nrrd
    Testing/data/use_normals/sphere30_DT.nrrd
    Testing/data/use_normals/sphere40_DT.nrrd

Maybe I need to add some of this. Especially when adding data for Testing this is frustrating.

akenmorris commented 3 years ago

Agreed. See also #637 and #1066.

cchriste commented 3 years ago

Removed:

D   Testing/data/sphere_cutting_plane_constraint/sphere10_DT.nrrd
D   Testing/data/sphere_cutting_plane_constraint/sphere20_DT.nrrd
D   Testing/data/sphere_cutting_plane_constraint/sphere30_DT.nrrd
D   Testing/data/sphere_cutting_plane_constraint/sphere40_DT.nrrd
cchriste commented 2 years ago

Some of these write results, then use them, and /tmp isn't available on all platforms. So a simple fix isn't as trivial as it seems. Everyone says use https://docs.python.org/3/library/tempfile.html. The only concern is that it seems to delete everything it created on close. This might be a problem if we need something to stay around for multiple scripts.