SCIInstitute / ShapeWorks

ShapeWorks
http://sciinstitute.github.io/ShapeWorks/
Other
103 stars 32 forks source link

All issues related shared bounday use case #1382

Open iyerkrithika21 opened 3 years ago

iyerkrithika21 commented 3 years ago

The use case has a few commands which are hardcoded. - done The necessary commands should be consolidated and replaced with the python API calls - done The following commands have to be changed:

Studio:

Other related tasks that are in the research stage:

The use case in python and studio should follow the steps:

  1. Given the input data, identify the pairs of data that have shared boundary
  2. If there are no shared boundaries, notify the user and proceed to build the shape model considering this a case of multiple domains
  3. If shard boundaries exist, then let the user know and proceed to build a shape model with mixed domain
iyerkrithika21 commented 3 years ago

Questions:

  1. There are 4 domains per shape in the use case - left, right, shared surface meshes, and boundary loop contour. How to update OptmizeUtils.py for such a use case which uses more than one input type?
cchriste commented 3 years ago
  1. There are 4 domains per shape in the use case - left, right, shared surface meshes, and boundary loop contour. How to update OptmizeUtils.py for such a use case which uses more than one input type?

We might want to split this issue out into separate issues that can be independently addressed.

sheryjoe commented 3 years ago

Agreed. We can use this issue as the parent one for the subissues.

akenmorris commented 1 year ago

@iyerkrithika21 , has this been completed?

iyerkrithika21 commented 1 year ago

@iyerkrithika21 , has this been completed?

We have implemented the shared boundary use case in python but two issues remain open:

  1. https://github.com/SCIInstitute/ShapeWorks/issues/1234 This is a general issue with mesh smoothening not particularly related to shared boundary use case
  2. 1383 where we were hoping to include the shared boundary detection and optimization in studio.