SCIInstitute / ShapeWorks

ShapeWorks
http://sciinstitute.github.io/ShapeWorks/
Other
103 stars 32 forks source link

Studio: Abort Optimization does not always seem to stop the optimization #1735

Closed patkins closed 2 years ago

patkins commented 2 years ago

I think this only occurs if optimization parameters have not been changed (and potentially only when done quickly after the start of optimization), but when trying to understand where particles are initializing, I hit the 'Abort Optimize' button as soon as particle optimization starts and then view where the first two particles are located. If done repeatedly, the particles seem to keep optimizing in the background (even if the project is reopened), such that if you press 'Run Optimize' it will start more than 2 particles, depending on the time that has passed.

patkins commented 2 years ago

In similar situations, but after changing parameters, when 'Run Optimization' is pressed and shapes have been loaded, it might say 'Optimizing correspondence...' at the bottom of the screen, but there are no particles on the surfaces and the 'Run Optimize' button is available. If you press 'Run optimize' it will show alternating progress reports for a low and high number of particles.

Note that I've only observed this happening, when I am running/aborting the optimize in quick iterations.

akenmorris commented 2 years ago

I'll look into it.

I'd also like to replace the behavior of the Run Optimize to be more like the DeepSSM Run button that disables temporarily so that you don't accidentally double click it and cancel.