Closed annehaley closed 4 months ago
As far as the analysis UI changes go: I think that this is fine, as it is more consistent with the DeepSSM tab, although I do think that from a UI/UX perspective it might be better to have the hamburger menu. Not a huge deal and I think the changes are fine to stay.
Your additional changes look good, thanks.
Resolves #364, Resolves #374
form_data
field toTaskProgress
and save form data upon creationTaskProgress
object after it is completedTaskProgress
objects belonging to a projectTaskProgress
object during a task. More message and percentage updates were made to the basic tasks (groom, optimize, analyze). @JakeWags Could you add message/percentage updates to the deepssm task?abort
field was only checked during the parsing of xml output. This meant that aborting would not work during the surrounding logic, nor would it work at all for the deepssm task. Now, theabort
field is checked any timeupdate_message
orupdate_percentage
are called. Ifabort
is True, a custom exceptionTaskAbortedError
will be raised. All tasks expect this exception at any time during the process and will exit gracefully if it occurs.TaskProgress
objects at all times. This ensures that if a task is active, the task progress bar will appear even if the user who spawned the task refreshes the page, or even if another user is looking at the task tab.TaskInfo
. This consolidates the logic for the progress bar, task progress messages and errors, the buttons to submit a task and reset a form, and the dialogs to confirm overwriting a previous task or aborting an active task. This reduces code repetition and enforces congruence between the tabs. @JakeWags This did involve heavy changes to the Analysis tab. I changed the UI to make the task submission form placement more similar to that of the DeepSSM tab (rather than being hidden in a three-dots menu). Let me know what you think of this change.