search

SCIInstitute / shapeworks-cloud

A web version of ShapeWorks Studio
https://www.shapeworks-cloud.org/#/
Apache License 2.0
1 stars 0 forks source link

Repository Maintenance #378

Closed annehaley closed 3 months ago

annehaley commented 3 months ago

Prior to officially transferring ownership and responsibility to the ShapeWorks folks at SCI, this PR does some final cleanup to ensure the project is in the best possible state for transfer. This includes bug fixes, refactoring, and other maintenance.

This PR also addresses a few "low-hanging fruit" issues: resolves #348, resolves #349

annehaley commented 3 months ago

Looks good. Is there a better way to stop propagation for the button click events, rather than adding .stop to each one?

Not that I know of, since we want all children except the buttons to propagate the event (otherwise clicking the Dataset title, etc. would not select it). The stop modifier is documented by Vue as the best approach to exclude certain components from event propagation: https://vuejs.org/guide/essentials/event-handling#event-modifiers. Of course, I am open to suggestion for other approaches.

JakeWags commented 3 months ago

Looks good. Is there a better way to stop propagation for the button click events, rather than adding .stop to each one?

Not that I know of, since we want all children except the buttons to propagate the event (otherwise clicking the Dataset title, etc. would not select it). The stop modifier is documented by Vue as the best approach to exclude certain components from event propagation: https://vuejs.org/guide/essentials/event-handling#event-modifiers. Of course, I am open to suggestion for other approaches.

That's fine. I don't think there would be an easy way to stop the prop with a class value or something. All looks great 👍