SCOAP3 / scoap3-next

Articles repository for SCOAP3 - enabling Open Access in HEP
https://scoap3.org
3 stars 6 forks source link

scoap3 nations parser #445

Closed ErnestaP closed 10 months ago

ErnestaP commented 1 year ago
drjova commented 1 year ago

Thank you, could you please give me an example with an extra whitespace?

ErnestaP commented 1 year ago

I tried to explain in the commit message. Is it not clear? Let's say there is an affiliation value: Guangdong-Hong Kong Joint Laboratory of Quantum Matter, Southern Nuclear Science Computing Center, South China Normal University, Guangzhou 510006, China

It was mapped as Hong Kong, but it has to be Chine

drjova commented 1 year ago

Maybe we should just change the the config for this case then instead?

ErnestaP commented 1 year ago

But then we need to change all values in the config, to have the same result. Do you think it's the correct approach?

drjova commented 1 year ago

But then we need to change all values in the config, to have the same result. Do you think it's the correct approach?

I mean to do something like here, is it possible? https://github.com/SCOAP3/scoap3-next/blob/b4703326a6041a371c9ab56fa7539709897653ec/scoap3/config.py#L699

ErnestaP commented 1 year ago

good point we can, just I would put almost a whole value: ("Guangdong-Hong Kong Joint Laboratory of Quantum Matter, Southern Nuclear Science Computing Center, South China Normal University", "China"), what do you think?

drjova commented 1 year ago

Guangdong-Hong Kong

From my understanding this Guangdong-Hong Kong should be enough. Could you please test it?

ErnestaP commented 1 year ago

Maybe I should ask Anne, just to make sure what is affiliation name? Just to be sure, what we actually parsing

drjova commented 1 year ago

Maybe I should ask Anne, just to make sure what is affiliation name? Just to be sure, what we actually parsing

Yes please