search

SCODEMeetup / community-services-locator-ui

Building a UI for community locator services
MIT License
1 stars 7 forks source link

Set zoom level on markers update #51

Open mycarrysun opened 5 years ago

mycarrysun commented 5 years ago

Going to need some help on this with someone who understands the HOC convention, it is a little over my head coming from Vuejs.

Would like to use this example to center and zoom the map when a set of locations is loaded as markers on the map. I have use in another project and it works great and is light on CPU.

What I need help with is making the markers prop on the MapClass component observable, so we can attach a handler anytime it changes and loop through to create a new bounds object which would then be able to set the zoom level.

Would appreciate anyone's expertise here who knows how to use the recompose library!

Side note: the recompose library is at EOL and will not be receiving future updates which can be a security concern if there are vulnerabilities...maybe we should consider removing this library to accommodate and go more vanilla React?

mihiramin89 commented 5 years ago

Yes I noticed the recompose library was EOL. Would love to change this to something that better follows react components. I do not particularly like putting majority of the code in one file.

I can try to take a stab at it in the next week or so.

Mihir

Sent from my iPhone

On Sep 24, 2019, at 8:07 PM, Mike Harrison notifications@github.com wrote:

 Going to need some help on this with someone who understands the HOC convention, it is a little over my head coming from Vuejs.

Would like to use this example to center and zoom the map when a set of locations is loaded as markers on the map. I have use in another project and it works great and is light on CPU.

What I need help with is making the markers prop on the MapClass component observable, so we can attach a handler anytime it changes and loop through to create a new bounds object which would then be able to set the zoom level.

Would appreciate anyone's expertise here who knows how to use the recompose library!

Side note: the recompose library is at EOL and will not be receiving future updates which can be a security concern if there are vulnerabilities...maybe we should consider removing this library to accommodate and go more vanilla React?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.

mycarrysun commented 5 years ago

@mihiramin89 excellent thanks for the help sir!

downtownbob commented 4 years ago

Taking this card - will reach out with any questions.