Residual Based Error Estimation

SCOREC / core

parallel finite element unstructured meshes

Other

183 stars 62 forks source link

Residual Based Error Estimation #311

Closed Samiullah-Malik closed 3 years ago

Samiullah-Malik commented 4 years ago

This pull request brings in the Residual Based Error Estimation for Time-Harmonic Maxwell's Equations (e.g., RF Heater). Items covered:

[x] implementations of the error estimation
[x] test for order 1 fields
[x] test for serial meshes

Note: Even though some of the stuff might be in-place for higher order (or parallel) meshes, such cases have not been tested properly.

mortezah commented 3 years ago

Looks good overall.

Please add ree to the readme:

https://github.com/SCOREC/core/blob/master/README.md#what-is-in-this-repository

@Samiullah-Malik is this done?

Samiullah-Malik commented 3 years ago

Looks good overall. Please add ree to the readme: https://github.com/SCOREC/core/blob/master/README.md#what-is-in-this-repository

@Samiullah-Malik is this done?

@mortezah Yes, this is done.

cwsmith commented 3 years ago

Thank you @Samiullah-Malik . I resolved most of the comments. Please look at the few unresolved comments and make the necessary changes.

Samiullah-Malik commented 3 years ago

Thank you @Samiullah-Malik . I resolved most of the comments. Please look at the few unresolved comments and make the necessary changes.

@cwsmith I have made the necessary changes for the remaining comments and pushed the new changes to the repo. Please let me know if there is anything else.

cwsmith commented 3 years ago

@Samiullah-Malik one more comment to address https://github.com/SCOREC/core/pull/311#discussion_r538744763

cwsmith commented 3 years ago

@mortezah @Samiullah-Malik Do you want me to merge this?

mortezah commented 3 years ago

@mortezah @Samiullah-Malik Do you want me to merge this?

Yes, that would be great. Thanks @cwsmith for the review.