SCOREC / core

parallel finite element unstructured meshes
Other
183 stars 62 forks source link

High-order Nodal Fields and Solution Transfer #325

Closed mortezah closed 4 years ago

mortezah commented 4 years ago

This pull request achieves the following

cwsmith commented 4 years ago

Looks good at first glance. I'll take a closer look tomorrow.

Please add any new source files to the pkg_tribits.cmake files in each directory.

mortezah commented 4 years ago

@cwsmith the new source are in the pkg_tribits.cmake

mortezah commented 4 years ago

@cwsmith

Do you know when this would be merged? A student I am working with will need these changes for his development.

cwsmith commented 4 years ago

Sorry for the delay. I'll look in about an hour.

mortezah commented 4 years ago

@cwsmith thanks for the reviews. I am going to merge this shortly if there are no more issues. Github has a few options

Which one is the suggested method?

cwsmith commented 4 years ago

You're welcome.

The answer depends on what history (sequence of commits) you want to exist in develop after the merge.

This appears like a decent, deeper, explanation of the differences: https://rietta.com/blog/github-merge-types/

mortezah commented 4 years ago

@cwsmith thanks.

I will do the merge commit, since I will need to refer to some of the commits (for code style and development purposes) when I work with the students.