search

SCOREC / core

parallel finite element unstructured meshes
Other
179 stars 63 forks source link

Build error when building SCOREC using Trilinos develop #348

Closed ikalash closed 3 years ago

ikalash commented 3 years ago

It looks like a build error has cropped up when building SCOREC under Trilinos (develop branch). I believe it is due to changes to the STK package. Here is the error: 

[ 76%] Building CXX object packages/tpetra/core/inout/CMakeFiles/tpetrainout.dir/Tpetra_MatrixIO.cpp.o
/home/ikalash/Trilinos_Albany/nightlyAlbanyTests/Results/Trilinos/SCOREC/stk/apfSTK.cc: In member function ‘void apf::StkBridge::transfer(apf::StkMetaData*, apf::StkBulkData*, apf::GlobalMap&, apf::GlobalMap&, bool)’:
/home/ikalash/Trilinos_Albany/nightlyAlbanyTests/Results/Trilinos/SCOREC/stk/apfSTK.cc:517:59: error: no matching function for call to ‘stk::mesh::BulkData::get_buckets(stk::mesh::EntityRank&, stk::mesh::Selector&, stk::mesh::BucketVector&)’
  517 |       bulkData->get_buckets(rank, overlapSelector, buckets);
      |                                                           ^
In file included from /home/ikalash/Trilinos_Albany/nightlyAlbanyTests/Results/Trilinos/packages/stk/stk_mesh/stk_mesh/base/FieldBase.hpp:41,
                 from /home/ikalash/Trilinos_Albany/nightlyAlbanyTests/Results/Trilinos/packages/stk/stk_mesh/stk_mesh/base/Field.hpp:40,
                 from /home/ikalash/Trilinos_Albany/nightlyAlbanyTests/Results/Trilinos/SCOREC/stk/apfSTK.h:12,
                 from /home/ikalash/Trilinos_Albany/nightlyAlbanyTests/Results/Trilinos/SCOREC/stk/apfSTK.cc:20:
/home/ikalash/Trilinos_Albany/nightlyAlbanyTests/Results/Trilinos/packages/stk/stk_mesh/stk_mesh/base/BulkData.hpp:802:23: note: candidate: ‘const BucketVector& stk::mesh::BulkData::get_buckets(stk::mesh::EntityRank, const stk::mesh::Selector&) const’
  802 |   BucketVector const& get_buckets(EntityRank rank, Selector const& selector) const;
      |                       ^~~~~~~~~~~
/home/ikalash/Trilinos_Albany/nightlyAlbanyTests/Results/Trilinos/packages/stk/stk_mesh/stk_mesh/base/BulkData.hpp:802:23: note:   candidate expects 2 arguments, 3 provided
make[2]: *** [SCOREC/stk/CMakeFiles/apf_stk.dir/apfSTK.cc.o] Error 1
make[1]: *** [SCOREC/stk/CMakeFiles/apf_stk.dir/all] Error 2
make[1]: *** Waiting for unfinished jobs....

Could someone please have a look at this?

cwsmith commented 3 years ago

@ikalash I pushed what I think is the fix for this to the pumi develop branch (https://github.com/SCOREC/core/commit/9790ed824cbbee939f18db7013a416691ba816e1). I'll see if I can get spack to build me a trilinos stk+pumi build to test it.

ikalash commented 3 years ago

@cwsmith : thanks, your commit fixes the problem! I am using master in my nightly tests of SCOREC. Should I switch to develop? How soon will this change make it into SCOREC master?

cwsmith commented 3 years ago

@ikalash Great. The develop branch will be merged into master tomorrow morning around 8am eastern.

ikalash commented 3 years ago

Ok, in this case, I will keep my tests using master I think. Thanks for fixing this so fast!