Closed bobpaw closed 3 days ago
I think there are scenarios where it makes sense to run the check. For example, if an mesh edge classified on the model boundary is being split then the point where it is split could be outside the domain of the geometric model. A crude drawing is attached.
for reference, can you add details on the adaptation inputs you're using? or a the link to the main function if available
for reference, can you add details on the adaptation inputs you're using? or a the link to the main function if available
This are the inputs we're using.
ma::Input* in;
in = ma::makeAdvanced(ma::configure(apfMesh, mdsScaleField, mdsFrameField));
in->shouldSnap = true;
in->shouldTransferParametric = true;
in->shouldFixShape = true;
in->shouldForceAdaptation = true;
if (apfMesh->getDimension() == 2)
in->goodQuality = 0.04; // this is mean-ratio squared
else // 3D meshes
in->goodQuality = 0.027; // this is the mean-ratio cubed
in->maximumIterations = 10;
We are calling it from a file similar to capstone_clis/capStoneAnisoAdapt.cc
For reference, this commit https://github.com/SCOREC/core/commit/4b514947ae542ea3a0bb436deac041d32cc0e343 added the check.
I believe this is closed by #446?
Yeah. It should be all set.
I'm reporting an issue in ma::adapt where an unnecessarily expensive call (depending on geometric complexity) is made to gmi_is_point_in_region.
Call stack (from gdb):
I'm not particularly well-versed in the adapt code, but this should be avoidable during adaptation.