SCOREC / redev

rendezvous communication library
https://scorec.github.io/redev/
BSD 3-Clause "New" or "Revised" License
2 stars 3 forks source link

adios_pair c2s/s2c #12

Closed jacobmerson closed 2 years ago

jacobmerson commented 2 years ago

@cwsmith As I'm setting up the rdv usage in the coupler. I came across the following question for you. I'm wondering if the client and server are actually different from the adios perspective.

My current workflow is to add a getter to Redev to get the process type (client/server) and then use this to determine which of c2s and s2c are the sending and receiving comms.

Now, if the server and client are essentially the same on the rendezvous side it may make sense to refactor those to be called something like sending comm and receiving comm (since rdv knows which is which upon construction). If we do this, then the user no longer needs to get access to the rdv process type.

cwsmith commented 2 years ago

The only difference between the client and server from the adios perspective is the read/write mode of each connection.

The idea is to rename the variables in the CommPair here?

https://github.com/SCOREC/redev/blob/655bfeebb93ec31503a9d0beaa11cae2f374f595/redev.h#L305-L318

jacobmerson commented 2 years ago

closed by #15