search

SCRT-HQ / PSGSuite

Powershell module for Google / G Suite API calls wrapped in handy functions. Authentication is established using a service account via P12 key to negate the consent popup and allow for greater handsoff automation capabilities
https://psgsuite.io/
Apache License 2.0
234 stars 67 forks source link

Gsheets #303

Closed FISHMANPET closed 4 years ago

FISHMANPET commented 4 years ago

OK these are two very minor changes, mentioned in #254. One is correcting an issue with "table" data outside the headers, and the other is just updating the documentation because the Append and BatchUpdate classes take different values for ValueInputOption (and honestly probably every other ENUM has bad help if the names have underscores, but one thing at a time).

I think it's actually a problem with the Google libraries, either how the .Net generator is interpreting the Sheets API discovery document or how the discovery document itself is generated, and have opened this issue to try and get the behavior normalized.

Since it looks like you're nearing a release I wanted to sneak these in, but if it's going to be a little while I can add some more "teeth" to my Gsheet changes.

scrthq commented 4 years ago

These changes look good! The doc update makes sense, thank you for that :-) I'll need to spend some more time looking at the change on Import-GSSheet but from a high-level it makes sense to me. LGTM!