SCS-CBU-CED-IAM / mobileid-helper

Mobile ID Test Signature Portal
1 stars 1 forks source link

APP_ERROR_DEFAULT should only apply to mss and subfaults #36

Closed SCS-CBU-CED-IAM closed 11 years ago

SCS-CBU-CED-IAM commented 11 years ago

I have seen that you have put the fallback in the getText function. This will put the APP_ERROR_DEFAULT to all untranslated/undefined elements:

    public function getText($define) {

        if (!strstr($this->defines[$define], '<a href')) {
            $text = htmlentities($this->defines[$define], null, 'utf-8');

            if (!strlen($text)) {
                $text = htmlentities($this->defines["APP_ERROR_DEFAULT"], null, 'utf-8');
            }

            return $text;
        }

The APP_ERROR_DEFAULT should only apply to Mobile ID errors