search

SCU-RSL-ROS / radar_omnipresense

Robotic Operating System (ROS) publisher and service for the OmniPreSense short range radar (originally OPS241-A) ECL-2.0
Educational Community License v2.0
4 stars 3 forks source link

No LinuxCommConnection src in the repo #1

Closed RyanLoringCooper closed 6 years ago

RyanLoringCooper commented 6 years ago

The changes on this branch removed LinuxCommConnection(LCC) src in the repo and its associated stuff in the CMakeLists.txt. I added the necessary things to link against LCC to the CMakeLists.txt. I modified README.md to have links to the repos that this repo is dependent on. I think it is best that we leave out instructions on how to install those dependencies because they may change. I tested that these changes did not break anything.

The major change is that the user will have to checkout LCC and run make install.

When you are happy with what I have changed, you can hit the green "Merge pull request" to put my changes into master. After this is merged, I would like to delete the LCC fork in this organization as it is not ROS related.

garrenhendricks commented 6 years ago

This moved LLC out of the src file for the package correct? Just like the rapidJson stuff now?

RyanLoringCooper commented 6 years ago

Yes, but not like rapidJson. For rapidJson, you needed a FindrapidJson thing, but that is unnecessary for LCC.

Sorry I didn't wait until Friday! I didn't want to study.

garrenhendricks commented 6 years ago

Not a problem. I will take a look at it though