SCUACM / ACM-Website

5 stars 8 forks source link

Rework events page #32

Closed rileywong311 closed 1 year ago

rileywong311 commented 1 year ago

Added a "Grid View" and "Calendar View" to the events page.

Grid View

GridView

Grid View Dialog Box When Clicked

image

Calendar View

CalendarView
rileywong311 commented 1 year ago

I tried this:

The entire page works the same still, maybe with minor styling changes, but feel free to check it out.

Whee-il commented 1 year ago

I still left the Calendar page on the Navbar because there would be more work in editing the routers and removing it from the Navbar, and, as above, also in case something broke by me making it a component. This could potentially be another commit on this branch though.

It feels weird to me to have the calendar in two places. Maybe I'm missing something but is it that bad to just remove it?

rileywong311 commented 1 year ago

No, I could just go in and remove it. In that case I'll try to do that soon

rileywong311 commented 1 year ago

My latest commit hides the calendar navbar tab if they are not a user. I opted to do this instead of deleting it because I think it's important to keep it for non-users (for example, so visitors know we're active). For users, the calendar page link will be hidden and instead it will be under the events page which is revealed to users.

I was looking into making the events page visible to all but querying user authentication to reveal certain elements, but I am unsure about the implementation so maybe keep this idea on the back-burner for now?