search

SCasanova / f1dataR

An R package to access Formula 1 Data from the Ergast API and the unofficial F1 data stream via the fastf1 python library.
https://scasanova.github.io/f1dataR/
Other
52 stars 5 forks source link

Change `setup_fastf1` to only help with install. #190

Closed pbulsink closed 11 months ago

pbulsink commented 11 months ago

Per #187

pbulsink commented 11 months ago

Still doesn't work on GH Actions. It's certainly because of the reticulate 1.32.0 update

The reticulate docs use r-tensorflow as example - and even it doesn't test the environment handling, but they do test lots of other stuff.

So, @SCasanova should we remove the test from the list?

codecov[bot] commented 11 months ago

Codecov Report

Merging #190 (fa986c4) into master (fdfcc52) will increase coverage by 0.52%. Report is 2 commits behind head on master. The diff coverage is 50.00%.

:exclamation: Current head fa986c4 differs from pull request most recent head 5554b66. Consider uploading reports for the commit 5554b66 to get more accurate results

@@            Coverage Diff             @@
##           master     #190      +/-   ##
==========================================
+ Coverage   92.66%   93.19%   +0.52%     
==========================================
  Files          18       18              
  Lines         641      617      -24     
==========================================
- Hits          594      575      -19     
+ Misses         47       42       -5
Files Coverage Δ
R/zzz.R 26.31% <ø> (ø)
R/utils.R 77.19% <50.00%> (-0.59%) :arrow_down:
SCasanova commented 11 months ago

Still doesn't work on GH Actions. It's certainly because of the reticulate 1.32.0 update

The reticulate docs use r-tensorflow as example - and even it doesn't test the environment handling, but they do test lots of other stuff.

So, @SCasanova should we remove the test from the list?

Hmm maybe. If that's their practice then it's not bad to follow. Especially now that it's causing issues