search

SCasanova / f1dataR

An R package to access Formula 1 Data from the Ergast API and the unofficial F1 data stream via the fastf1 python library.
https://scasanova.github.io/f1dataR/
Other
52 stars 5 forks source link

Test Suite Failures #216

Closed pbulsink closed 7 months ago

pbulsink commented 7 months ago

Failures seen in recent PR unrelated to the new code being committed. See failures in #211,#213 (specifically something like https://github.com/SCasanova/f1dataR/actions/runs/7597232191/job/20691818003?pr=213)

Error ('test-load_session_laps.R:18:3'): load session laps works ────────────
<python.builtin.AttributeError/python.builtin.Exception/python.builtin.BaseException/python.builtin.object/error/condition>
Error in `py_run_string_impl(code, local, convert)`: AttributeError: 'NoneType' object has no attribute 'name'
Run `reticulate::py_last_error()` for details.
Backtrace:
    ▆
 1. └─f1dataR (local) `<fn>`(season = 2022, round = "bahrain", session = "Q", add_weather = TRUE)
 2.   └─reticulate::py_run_string(...) at f1dataR/R/load_session_laps.R:65:5
 3.     └─reticulate:::py_run_string_impl(code, local, convert)

Fails in nearly every R CMD CHK test and code coverage.

pbulsink commented 7 months ago

@SCasanova Do you want this fixed before merging #211?

SCasanova commented 7 months ago

Not necessarily. I'm ok with the extra functionality if it's just a bug

pbulsink commented 7 months ago

I might merge #213 as well, it'll only help with tracking down this issue.